Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/terry responsive #51

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

eltel
Copy link

@eltel eltel commented Jun 10, 2020

UPDATED - now signed with GPG, after multiple attempts to configure GPG on Linux:

Hi guys

Implemented basic media queries written up for Typescript - responsiveness between 3 main device types is in place and easily tweaked once someone with a design eye has had a look - easily expandable to more device types (retina screens etc).

I hope this helps, I've not had time to go over all the docs - but this is working great locally. Let me know if I've messed up in my submission

Cheers

Terry

@vercel
Copy link

vercel bot commented Jun 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click on the icon next to each commit.

@eltel
Copy link
Author

eltel commented Jun 10, 2020

Hmmm...Apparently I'm not authorised - any tips as to how I go about getting authorised?

@replygirl replygirl changed the base branch from master to dev June 10, 2020 19:33
@replygirl
Copy link
Contributor

hey @eltel, thanks for settings this up. could you abstract your media queries into a separate file so they can be imported elsewhere?

also please do not change quote types, add unnecessary semicolons, etc. unless your pull request is explicitly for code style. best to separate the concerns, plus we are having the style discussion soon

@eltel
Copy link
Author

eltel commented Jun 10, 2020

hey @eltel, thanks for settings this up. could you abstract your media queries into a separate file so they can be imported elsewhere?

also please do not change quote types, add unnecessary semicolons, etc. unless your pull request is explicitly for code style. best to separate the concerns, plus we are having the style discussion soon

OK, will do - my linter is set up for React/JS, not Typescript so it's all automated - I'll pay more attention to this in future. Hope to get this sorted by the end of the day (Brazil time!)

@replygirl replygirl linked an issue Jun 16, 2020 that may be closed by this pull request
@replygirl replygirl added the ✨ enhancement Addition to existing feature label Jun 16, 2020
@sparklestheunicorn
Copy link
Collaborator

While we're in here, it might be good to remove components/constants.js and switch over TourBar.tsx and TourNavButton.tsx to use styles/_breakpoints.styl instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement Addition to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make World of Jackson Responsive
3 participants