support for yzlsm and qlsm for bo #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephoris
reviewed
Feb 23, 2024
| return bounds | ||
|
|
||
| def get_next_points(self, x: torch.Tensor, y: torch.Tensor, best_y: float, bounds: torch.Tensor, | ||
| acquisition_function: str = "ExpectedImprovement", n_points: int = 1) -> torch.Tensor: | ||
| single_model = MixedSingleTaskGP(x, y, cat_dims=[1, 2], input_transform=Normalize(d=x.shape[1], bounds=bounds), | ||
| outcome_transform=Standardize(m=1)) | ||
| if self.model_type == "QHybrid" or self.model_type == "Classic": |
There was a problem hiding this comment.
At some point (and this does not need to be addressed in this PR), we should move away from str types and use the Enum provided in lsm/types.py:6
|
Changes look good! Squash and merge at this point and create a new branch if you need more development/changes. |
ephoris
pushed a commit
that referenced
this pull request
Apr 23, 2024
* added support for yzlsm and qlsm for bo * qlsm solver update * remove redundant call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code for handling YZLSM and QLSM