Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mixed acqf support #9

Merged
merged 2 commits into from
Feb 13, 2024
Merged

added mixed acqf support #9

merged 2 commits into from
Feb 13, 2024

Conversation

aquaorifice
Copy link
Collaborator

Added support to write to database and create/update on call to EndureCost
Modified code to run with updated changes to other modules (Generator/EndureCost)
Added support for categorical values - T and policy
Added requirements file for running botorch

@aquaorifice aquaorifice requested a review from ephoris February 12, 2024 05:55
Copy link
Collaborator

@ephoris ephoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Add the DB default to the TOML file and then should be good to merge.

jobs/bayesian_pipeline.py Outdated Show resolved Hide resolved
@ephoris
Copy link
Collaborator

ephoris commented Feb 13, 2024

Looks good! @aquaorifice feel free to squash and merge.

@aquaorifice aquaorifice merged commit 46d00ce into main Feb 13, 2024
3 checks passed
@aquaorifice aquaorifice deleted the categorical_bo branch February 23, 2024 21:00
ephoris pushed a commit that referenced this pull request Apr 23, 2024
* added mixed acqf support

* added option for db name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants