Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized MenuManager.java #111

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Optimized MenuManager.java #111

merged 1 commit into from
Dec 16, 2024

Conversation

DimaSergeew
Copy link
Contributor

Optimized MenuManager:

  • We now cache all static items instead of rebuilding them every tick.
  • The "next" items are also cached, and we only update their lore's time each second.
  • This avoids expensive operations like fromStringToJSON on every tick.
  • Overall, this should drastically reduce lag.

@DimaSergeew
Optimized MenuManager.java
5578dee 
 Optimized MenuManager:
 - We now cache all static items instead of rebuilding them every tick.
 - The "next" items are also cached, and we only update their lore's time each second.
 - This avoids expensive operations like fromStringToJSON on every tick.
 - Overall, this should drastically reduce lag.
@NONPLAYT NONPLAYT self-requested a review December 16, 2024 14:21
@NONPLAYT NONPLAYT added 🔧 feature New feature or request ✅ needs testing Issue needs verification. labels Dec 16, 2024
@NONPLAYT NONPLAYT added this to the NDailyRewards 3.2.0 milestone Dec 16, 2024
@NONPLAYT NONPLAYT changed the base branch from master to develop December 16, 2024 14:38
NONPLAYT
NONPLAYT approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@NONPLAYT NONPLAYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving this performance problem, everything seems to be working

@NONPLAYT NONPLAYT merged commit cdfc999 into BX-Team:develop Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NONPLAYT NONPLAYT NONPLAYT approved these changes

Assignees
No one assigned
Labels
🔧 feature New feature or request ✅ needs testing Issue needs verification.
Projects
None yet
Milestone
NDailyRewards 3.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@DimaSergeew @NONPLAYT