Optimize MenuManager and InventoryClickListener for improved server p… #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erformance and memory management - Replaced individual `BukkitTask` instances per player with a single global scheduled task to handle inventory updates, reducing CPU and memory overhead. - Cached static `ItemStack` objects (filler and custom items) to eliminate repetitive creation and cloning. - Precomputed slot-to-day mappings (`slotToDayMap`) for efficient event handling during inventory clicks. - Reduced frequency of `ItemStack` cloning by reusing cached templates and only updating mutable parts (e.g., time left in lore). - Utilized `ConcurrentHashMap.newKeySet()` to safely track players with open menus, ensuring thread-safe operations. - Implemented `InventoryCloseListener` to remove players from the tracking set when they close the rewards menu, preventing potential memory leaks. - Optimized click event processing by using pre-cached action lists for custom buttons, minimizing configuration accesses. - Added error handling for invalid sound configurations to prevent plugin crashes. - Streamlined code structure for better readability and maintainability, adding clear comments for future developers.
NONPLAYT
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erformance and memory management
BukkitTaskinstances per player with a single global scheduled task to handle inventory updates, reducing CPU and memory overhead.ItemStackobjects (filler and custom items) to eliminate repetitive creation and cloning.slotToDayMap) for efficient event handling during inventory clicks.ItemStackcloning by reusing cached templates and only updating mutable parts (e.g., time left in lore).ConcurrentHashMap.newKeySet()to safely track players with open menus, ensuring thread-safe operations.InventoryCloseListenerto remove players from the tracking set when they close the rewards menu, preventing potential memory leaks.