Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in README #150

Merged
merged 1 commit into from
Nov 28, 2024
Merged

doc: fix typo in README #150

merged 1 commit into from
Nov 28, 2024

Conversation

vegerot
Copy link
Contributor

@vegerot vegerot commented Nov 21, 2024

macOS hasn't been called "Mac OS" for a while

@vegerot
doc: fix typo in README
19e84a7 
macOS hasn't been called "Mac OS" for a while
@JackLau1222
Copy link
Collaborator

JackLau1222 commented Nov 21, 2024 •
edited
Loading

macOS hasn't been called "Mac OS" for a while

macOS is indeed a more modern name, mac OS usually refers to Classic Mac OS which is the series of operating systems developed for the Macintosh family of personal computers by Apple Computer, Inc. from 1984 to 2001, starting with System 1 and ending with Mac OS 9. you can find more details at this link

@vegerot
Copy link
Contributor Author

vegerot commented Nov 22, 2024

@JackLau1222 I don't understand if you're disagreeing with me or not...

My patch is to change the name to the modern one

@JackLau1222
Copy link
Collaborator

@JackLau1222 I don't understand if you're disagreeing with me or not...

My patch is to change the name to the modern one

Sorry, maybe I didn't express my meaning clearly. I agree with your point of view. I just added some relevant information for maintainer review. Thanks for your contribution

@vegerot
Copy link
Contributor Author

vegerot commented Nov 28, 2024

Thanks. So what're the next steps for landing this patch?

@JackLau1222 JackLau1222 merged commit a7d1669 into BabitMF:master Nov 28, 2024
2 checks passed
jonahmvp pushed a commit that referenced this pull request Dec 20, 2024
@vegerot @jonahmvp
doc: fix typo in README (#150)
89b59a7 
macOS hasn't been called "Mac OS" for a while
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackLau1222 JackLau1222 JackLau1222 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vegerot @JackLau1222