Feature/ingest arrangement id for pmts #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jan-Nel
requested review from
uesleilima,
ssj22,
shafiquech,
sushiljoshi22,
tarun-bb,
BB-ASehmi,
sunithabackbase and
piotr-backbase
BB-ASehmi
approved these changes
Aug 15, 2023
shafiquech
approved these changes
Aug 15, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will allow the payments to ingest the arrangement Id they are associated with it without the need to pass the ID in the request. The payment composition service will use the external arrangement ID (from the core) to retrieve the internal ID.
Added back the no-scs tag back because we were unable to get these images to run on a Baas env without it.
Updated the application-local.yml files to be in line with the new BE local env instead of the old Blade setup.
There was a bug which occurred because the newer versions of DBS pulls only 10 pmts from the DB by default. I now specify the maximum size that needs to be pulled.
Checklist