this will let joint owners own the same payments and avoid duplicates #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shafiquech
approved these changes
Jul 26, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, during pmt ingestion, we query the payment-order-service to retrieve a list of existing pmts. That way we can see what needs to be updated and what is new. We query these pmts by using the user's id.
Unfortunately, as soon as we introduce joint users, then not all the payments will come up. This results in duplicates being created.
This update will query the payment-order-service by using the arrangement ids associated with the payment. This way should eliminate any duplicates.
Checklist