Skip to content

Commit

Permalink
remove old todos
Browse files Browse the repository at this point in the history
  • Loading branch information
mpnowacki-reef committed Nov 23, 2023
1 parent 9ca9d0a commit 4293ef7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions b2sdk/sync/action.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ def do_action(self, bucket: Bucket, reporter: ProgressReport) -> None:
"""
bucket.hide_file(self.b2_file_name)

# TODO: This function uses SyncReport.update_transfer, while others are enough with ProgressReport interface.
def do_report(self, bucket: Bucket, reporter: SyncReport):
"""
Report the hiding action performed.
Expand Down Expand Up @@ -464,7 +463,6 @@ def do_action(self, bucket: Bucket, reporter: ProgressReport):
"""
bucket.api.delete_file_version(self.file_id, self.b2_file_name)

# TODO: This function uses SyncReport.update_transfer, while others are enough with ProgressReport interface.
def do_report(self, bucket: Bucket, reporter: SyncReport):
"""
Report the deleting action performed.
Expand Down Expand Up @@ -506,7 +504,6 @@ def do_action(self, bucket: Bucket, reporter: ProgressReport):
"""
os.unlink(self.full_path)

# TODO: This function uses SyncReport.update_transfer, while others are enough with ProgressReport interface.
def do_report(self, bucket: Bucket, reporter: SyncReport):
"""
Report the deleting of a local file action performed.
Expand Down
2 changes: 1 addition & 1 deletion test/unit/replication/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def source_bucket(api, destination_bucket) -> Bucket:
ReplicationRule(
destination_bucket_id=destination_bucket.id_,
name='name',
file_name_prefix='folder/', # TODO: is last slash needed?
file_name_prefix='folder/',
),
],
source_key_id='hoho|trololo',
Expand Down

0 comments on commit 4293ef7

Please sign in to comment.