Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of things to consider for apiver v2 #139

Open
ppolewicz opened this issue Jun 21, 2020 · 6 comments
Open

List of things to consider for apiver v2 #139

ppolewicz opened this issue Jun 21, 2020 · 6 comments

Comments

@ppolewicz
Copy link
Collaborator

ppolewicz commented Jun 21, 2020

  • Add support for XDG_CONFIG_HOME #129
  • replace InMemoryAccountInfo with SqliteAccountInfo and a special :memory: file, see here
  • change all path arguments everywhere (internally too) to use pathlib instead of strings
@mlech-reef
Copy link
Collaborator

  • change the API of SyncReport
  • the API should not exit from the given ProgressListener. It should be used as a context manager by the user as described in the documentation.

@mlech-reef
Copy link
Collaborator

  • able to set the timeout per API call, not globally
  • better format of progress reporting in SyncReport. Maybe merge total and compared as it's only different when the source is local.

@mlech-reef
Copy link
Collaborator

mlech-reef commented Oct 15, 2020

  • remove the workaround of setting time

^ no longer applicable

@mlech-reef mlech-reef added this to the ApiVer v2 milestone Feb 11, 2021
@mlech-reef
Copy link
Collaborator

@mpnowacki-reef
Copy link
Collaborator

change RawApi to RawHttpApi in v2

@mpnowacki-reef
Copy link
Collaborator

Some of the suggestions above did not make it to apiver v2 (but were not discarded):

  • replace InMemoryAccountInfo with SqliteAccountInfo and a special :memory: file, see here - this can be done in backward compatible way, and therefore does not require an apiver bump up
  • change all path arguments everywhere (internally too) to use pathlib instead of strings
  • the API should not exit from the given ProgressListener. It should be used as a context manager by the user as described in the documentation.
  • able to set the timeout per API call, not globally

@mpnowacki-reef mpnowacki-reef removed this from the ApiVer v2 milestone Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants