-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ScanPoliciesManager interface (see TODOs) #196
Comments
@mlech-reef Why is this needed for V2? |
It breaks compatibility. |
@ppolewicz In light of
from #139 should |
I think the problem here is that |
The way @mlech-reef Is this interface change somehow needed elsewhere? Or do you need access to all B2File versions (carried by B2File) in your implementation of |
However, changing the interface to have the following methods:
and performing the translations internally would make for a clean, extensible API. The problem is that |
@mpnowacki-reef The TODO was created just to not operate on str-like object carrying paths. Just for that. |
ScanPoliciesManager.should_exclude_file
should acceptFile
object, not stringScanPoliciesManager.should_exclude_directory
should acceptAbstractFolder
object, not stringThe text was updated successfully, but these errors were encountered: