-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileVersionInfo refactored to FileVersion, ScanPoliciesManager interface refactored, several other improvements #254
Merged
ppolewicz
merged 34 commits into
Backblaze:master
from
reef-technologies:feat/FileVersionRefactor
May 29, 2021
Merged
FileVersionInfo refactored to FileVersion, ScanPoliciesManager interface refactored, several other improvements #254
ppolewicz
merged 34 commits into
Backblaze:master
from
reef-technologies:feat/FileVersionRefactor
May 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_path and dest_path
…based FileVersionInfo renamed to FileVersion
…ng python 3.9 support
…actor2 ScanPoliciesManager refactored
ppolewicz
approved these changes
May 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been incrementally reviewed in 3 parts, 2 people each part.
We have added a couple of interface changes to the scope in anticipation of a large impact feature which is going to happen soon, to avoid another apiver increase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #196