Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom animations #11

Open
jonasman opened this issue Apr 2, 2014 · 6 comments
Open

custom animations #11

jonasman opened this issue Apr 2, 2014 · 6 comments

Comments

@jonasman
Copy link

jonasman commented Apr 2, 2014

It would be cool if we could pass a block for our custom animations, or to pass a class to do the custom animation.

Anyway the control is great!

@jonasman
Copy link
Author

jonasman commented Apr 3, 2014

I just forked this repo and im working on it

@jonasman
Copy link
Author

jonasman commented Apr 3, 2014

it turned out this is more complicated to add the functionality i wanted. I can pull request the basic functionality. But what i wanted was to add a CAKeyframe animation.

@jonasman
Copy link
Author

jonasman commented Apr 3, 2014

#12

@sparga
Copy link
Collaborator

sparga commented Apr 3, 2014

Thank you. Custom animations were planned for v1 but I faced a lot of questions about how to do it properly so I delayed it.
First, I was thinking of a custom block like you. It is simple but it is not so flexible.
Now, I am thinking about a solution inspired by UIViewControllerAnimatedTransitioningwhich appears in iOS 7. It is a little more complicated and require more time to implement it but it is really flexible.

  • It would be possible to use any animation method (CAAnimation, UIKit Dynamics) to create custom transitions
  • Better reusability of custom transition animations as they would be implemented in a separated class

@jonasman
Copy link
Author

jonasman commented Apr 3, 2014

I didnt have time to look in detail to that transition but what i have seen you just need a delegate and all the info comes from there. It could be a great way too :D

@grabbou
Copy link

grabbou commented Mar 30, 2015

Well, you can just display it with animated:NO property and then, tweak the layer as you normally do with e.g. facebook/pop to achieve custom navigation controller transitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants