Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic custom animations and a fix for the view being accessed before adding it to the parent controller #12

Merged
merged 3 commits into from
Apr 29, 2014

Conversation

jonasman
Copy link

@jonasman jonasman commented Apr 3, 2014

Added an iPhone example

Added an iPhone example
@jonasman jonasman mentioned this pull request Apr 3, 2014
@sparga
Copy link
Collaborator

sparga commented Apr 3, 2014

Thank you for the pull request.
I have quickly reviewed the code and it seems good. One thing, when you set a block with objc_setAssociatedObject the last parameter should be OBJC_ASSOCIATION_COPY instead of OBJC_ASSOCIATION_RETAIN_NONATOMIC. Like with properties, a block should always be copied.

I will check it more precisely. See my answer for issue #11, custom blocks are a simple solution but it lacks some flexibility as you noticed. Maybe for a v1.x it is enough and wait for the next major release to implement a better solution. I will also ask @leverdeterre about that.

@jonasman
Copy link
Author

jonasman commented Apr 3, 2014

Yeah! that COPY must be changed.

For a better implementation we need to give full control to the block or delegate call.
Another option is to create a class to make the animations and that class accept any kind of animation and also adds "pre installed" animations. Then you just ask this calss for an animation.

Kinda like some other libs are doing.

@jonasman jonasman closed this Apr 3, 2014
@jonasman jonasman reopened this Apr 3, 2014
changed the property association type to copy
@jonasman
Copy link
Author

jonasman commented Apr 3, 2014

I just made 1 more commit to fix those

@jonasman jonasman changed the title Added basic custom animations Added basic custom animations and a fix for the view being accessed before adding it to the parent controller Apr 29, 2014
@sparga sparga merged commit 2a71789 into Backelite:master Apr 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants