18 translators #56
18 translators #56
Conversation
| # gem 'linecache19', :git => 'git://github.com/mark-moseley/linecache' | ||
| gem 'devise' | ||
| gem 'font-awesome-rails' | ||
| gem 'audited-activerecord' |
There was a problem hiding this comment.
@mohamagdy why we removed those gems from Gemfile?
I can see you added them to gemspec. Actually, I am not sure why we didn't add them in gemspec before but are you sure that won't have some bad effect?
There was a problem hiding this comment.
@mahkhaled yes, it's a good practice to move the gems to Gemfile and to Gemfile the following:
source "http://rubygems.org"`
gemspecBesides, it's a good practice to remove Gemfile.lock from Git tracking so it shouldn't force the gem users from using the exact versions of the gem dependencies. For example, if in the Gemfile.lock devise 1.3.2 is used, this will force the users to use devise 1.3.2.
Source:
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
There was a problem hiding this comment.
+1 then lets remove Gemfile.lock from git
|
SonarCloud Quality Gate failed.
|
Adding Bing Translator suggestion. #55 is merged into this branch to add
rspectests