Jquery ui rails v5 #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As the latest Rails 3 version is 3.2.22 and maybe further will come along (only as security updates, if someone will be willing to apply it), I have loosen the requirement for Rails in .gemspec |
| @@ -17,7 +17,7 @@ Gem::Specification.new do |s| | |||
| s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.md"] | |||
| s.test_files = Dir["test/**/*"] | |||
|
|
|||
| s.add_dependency "rails", ">= 3.1.0", "<= 3.2.12" | |||
| s.add_dependency "rails", ">= 3.1.0", "<= 3.2.40" | |||
There was a problem hiding this comment.
We will have to update this every new version?
Wouldn't doing the following be better?
s.add_dependency "rails", ">= 3.1.0", "~> 3.2"
There was a problem hiding this comment.
Good point! However "> 3.2" that you suggested will also catch the update to version Rails 3.3 ;-) Sure there will not be Rails 3.3, but it should rather be eg. "> 3.2.19". I will correct it accordingly.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the security issues with old versions of jquery-ui-rails, it would be reasonable to require jquery-ui-rails ~> 5.0.