New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #333: Moved frame limiter to base plugin #342

Merged

Baekalfen merged 1 commit into Baekalfen:master from daivikbhatia:issue-333-fix

Sep 12, 2024

daivikbhatia commented Sep 7, 2024 •

edited

Loading

#333 Moved frame limiter to base plugin

Moved the frame limiter function from OpenGL window and SDL2 Window to PyBoyWindowPlugin so it can also run on Null window.
The frame limiter function should work same as before on OpenGL window and SDL2 Window as both of them can inherit the function from PyBoyWindowPlugin.

Owner

Baekalfen commented Sep 10, 2024

Great job! You have introduced a few print statements. If you remove these, I think we're ready to merge


          Fixed issue Baekalfen#333: Moved frame limiter from open_gl and sdl2 …

f9d3aea

…window to PyBoyWindowPlugin

Baekalfen force-pushed the issue-333-fix branch from 16265b6 to f9d3aea Compare

September 12, 2024 19:07

Baekalfen approved these changes

View reviewed changes

Baekalfen enabled auto-merge (rebase)

September 12, 2024 19:09

Baekalfen merged commit b52a84a into Baekalfen:master

28 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet