Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyBoyPlugin Cython move cgb attribute #364

Merged
merged 1 commit into from
Feb 12, 2025
Merged

PyBoyPlugin Cython move cgb attribute #364

merged 1 commit into from
Feb 12, 2025

Conversation

BackrndSource
Copy link
Contributor

Only Debug and BaseDebugWindow are using the cgb attribute.

I am making these small pull requests so as not to mix the code with the next pull request to load plugins dynamically.

@Baekalfen Baekalfen force-pushed the baseplugin-fix branch 2 times, most recently from 16a8aa7 to d864a1a Compare February 12, 2025 09:56
Baekalfen
Baekalfen approved these changes Feb 12, 2025
View reviewed changes
Copy link
Owner

@Baekalfen Baekalfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your reason, but it might be a short-lived change until another plugin needs the cgb attribute. Instead, I noticed that they were interpreting the cgb state differently, so I cleaned that up.

@Baekalfen Baekalfen enabled auto-merge (rebase) February 12, 2025 09:58
@Baekalfen Baekalfen merged commit 18b656e into Baekalfen:master Feb 12, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baekalfen Baekalfen Baekalfen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BackrndSource @Baekalfen