-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove bal_addresses deps #70
Conversation
this will require removing looks like its being used in two places afaik: |
btw had to add sonic to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing! that fix in protocol_fee_allocator_v2 is minimal and clean. it correctly (imo) moves the dependency to that repo instead of this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- correct removal of bal_addresses dependency in requirements.txt
- simple code linting in some components
- removal of resolve_address method calling address book
- fetching chain-specific data via raw json instead of address book dependency
- tests simplified
@jalbrekt85 can you try and finalise this pr by remove the bal_addresses dep from safe_tx_builder and conftest?
that will then remove the weird circular dependency between bal_tools and bal_addresses which is blocking #69