Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIP-788] Grant Maxi Multisig set_reward_distributor permissions #1797

Conversation

Zen-Maxi
Copy link
Collaborator

Copy link
Contributor

github-actions bot commented Feb 24, 2025

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-arb1.json
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-avax.json
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-base.json
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-gno.json
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-mainnet.json
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-opti.json
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-poly.json
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

Copy link
Contributor

github-actions bot commented Feb 24, 2025

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-arb1.json
MULTISIG: multisigs/dao (arbitrum:0xaF23DC5983230E9eEAf93280e312e57539D098D0)
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b
CHAIN(S): arbitrum
TENDERLY: 🟩 SUCCESS

+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function             | caller_name         | caller_address                             | fx_paths                                                                                      | action_ids                                                         |   bip   | tx_index |
+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRole | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20230316-child-chain-gauge-factory-v2/ChildChainGauge/set_reward_distributor(address,address) | 0xa7ed295af0b197c9481510d6c8326ba2e2d17b2c1a89ab1834ac80de9220b60e | BIP-788 |    0     |
|                      |                     |                                            | 20220413-child-chain-gauge-factory/ChildChainStreamer/set_reward_distributor(address,address) |                                                                    |         |          |
+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-avax.json
MULTISIG: multisigs/dao (avalanche:0x17b11FF13e2d7bAb2648182dFD1f1cfa0E4C7cf3)
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b
CHAIN(S): avalanche
TENDERLY: 🟩 SUCCESS

+----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function             | caller_name         | caller_address                             | fx_paths                                                                                           | action_ids                                                         |   bip   | tx_index |
+----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRole | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20230316-avax-child-chain-gauge-factory-v2/ChildChainGauge/set_reward_distributor(address,address) | 0xce713085e9498c958964f4c64979785027e7a93323b68bca8e87296c696fa643 | BIP-788 |    0     |
|                      |                     |                                            | 20230316-child-chain-gauge-factory-v2/ChildChainGauge/set_reward_distributor(address,address)      |                                                                    |         |          |
|                      |                     |                                            | 20220413-child-chain-gauge-factory/ChildChainStreamer/set_reward_distributor(address,address)      |                                                                    |         |          |
+----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-base.json
MULTISIG: multisigs/dao (base:0xC40DCFB13651e64C8551007aa57F9260827B6462)
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b
CHAIN(S): base
TENDERLY: 🟩 SUCCESS

+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function             | caller_name         | caller_address                             | fx_paths                                                                                      | action_ids                                                         |   bip   | tx_index |
+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRole | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20230316-child-chain-gauge-factory-v2/ChildChainGauge/set_reward_distributor(address,address) | 0x82f054fdfa86620d25b289d7f068681a5224bcfc083243cdb49512fe1574a36f | BIP-788 |    0     |
+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-gno.json
MULTISIG: multisigs/dao (gnosis:0x2a5AEcE0bb9EfFD7608213AE1745873385515c18)
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b
CHAIN(S): gnosis
TENDERLY: 🟩 SUCCESS

+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function             | caller_name         | caller_address                             | fx_paths                                                                                      | action_ids                                                         |   bip   | tx_index |
+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRole | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20230316-child-chain-gauge-factory-v2/ChildChainGauge/set_reward_distributor(address,address) | 0x9d575f62420250ec382e1e8e262ddae46d0d6817fab9fde48f9c6efd068e5844 | BIP-788 |    0     |
|                      |                     |                                            | 20220413-child-chain-gauge-factory/ChildChainStreamer/set_reward_distributor(address,address) |                                                                    |         |          |
+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-mainnet.json
MULTISIG: multisigs/dao (mainnet:0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f)
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+----------------------+---------------------+--------------------------------------------+--------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function             | caller_name         | caller_address                             | fx_paths                                                                                   | action_ids                                                         |   bip   | tx_index |
+----------------------+---------------------+--------------------------------------------+--------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRole | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20220325-mainnet-gauge-factory/LiquidityGaugeV5/set_reward_distributor(address,address)    | 0xd0090a09f425bba74e6c801fba7c6d15b44147ab0bd319e40076ce07e95168b6 | BIP-788 |    0     |
|                      |                     |                                            | 20220822-mainnet-gauge-factory-v2/LiquidityGaugeV5/set_reward_distributor(address,address) |                                                                    |         |          |
+----------------------+---------------------+--------------------------------------------+--------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-opti.json
MULTISIG: multisigs/dao (optimism:0x043f9687842771b3dF8852c1E9801DCAeED3f6bc)
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b
CHAIN(S): optimism
TENDERLY: 🟩 SUCCESS

+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function             | caller_name         | caller_address                             | fx_paths                                                                                      | action_ids                                                         |   bip   | tx_index |
+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRole | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20230316-child-chain-gauge-factory-v2/ChildChainGauge/set_reward_distributor(address,address) | 0xd0090a09f425bba74e6c801fba7c6d15b44147ab0bd319e40076ce07e95168b6 | BIP-788 |    0     |
|                      |                     |                                            | 20220413-child-chain-gauge-factory/ChildChainStreamer/set_reward_distributor(address,address) |                                                                    |         |          |
+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W13/BIP-788-set_reward_distributor-perms-poly.json
MULTISIG: multisigs/dao (polygon:0xeE071f4B516F69a1603dA393CdE8e76C40E5Be85)
COMMIT: f166d725edf66ed485aabe96164ed359edbd2e4b
CHAIN(S): polygon
TENDERLY: 🟩 SUCCESS

+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function             | caller_name         | caller_address                             | fx_paths                                                                                      | action_ids                                                         |   bip   | tx_index |
+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRole | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20230316-child-chain-gauge-factory-v2/ChildChainGauge/set_reward_distributor(address,address) | 0x363cf2bd771efe16bd206d33a549d4698c4ad202ea6b5bf693722fbe151140a6 | BIP-788 |    0     |
|                      |                     |                                            | 20220413-child-chain-gauge-factory/ChildChainStreamer/set_reward_distributor(address,address) |                                                                    |         |          |
+----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

@Xeonus Xeonus changed the title [BIP-XXX] Grant Maxi Multisig set_reward_distributor permissions-arb1 [BIP-788] Grant Maxi Multisig set_reward_distributor permissions Feb 26, 2025
Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zen-Maxi the permission for ethereum you link to (0xd0090a09f425bba74e6c801fba7c6d15b44147ab0bd319e40076ce07e95168b6) isnt being used in the ethereum payload? seems to be add_reward instead

forum post for ref: https://forum.balancer.fi/t/bip-788-grant-maxi-multisig-set-reward-distributor-permissions/6369

- set correct action id for set_reward for mainnet
@gosuto-inzasheru gosuto-inzasheru merged commit cfbd0df into main Mar 3, 2025
2 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the BIP-XXX-Grant-Maxi-Multisig-set_reward_distributor-permissions branch March 3, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants