Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BIP-789] Grant Maxis Parameter Control on the MEV Tax Hook #1799

Merged
merged 4 commits into from
Mar 3, 2025
Merged

[BIP-789] Grant Maxis Parameter Control on the MEV Tax Hook #1799

merged 4 commits into from
Mar 3, 2025

Conversation

Xeonus
Copy link
Collaborator

@Xeonus Xeonus commented Feb 25, 2025

  • Proposal
  • grant MEV tax hook roles on Base (exclusive hook for Base atm) to Omnisig

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

FILENAME: BIPs/2025-W13/BIP-789-mev-hook-roles-base.json
COMMIT: 44195289aace680954dccf188644a16a4d84c46a

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅
validate_file_has_bip ✅
validate_path_has_weekly_dir ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

FILENAME: BIPs/2025-W13/BIP-789-mev-hook-roles-base.json
MULTISIG: multisigs/dao (base:0xC40DCFB13651e64C8551007aa57F9260827B6462)
COMMIT: 44195289aace680954dccf188644a16a4d84c46a
CHAIN(S): base
TENDERLY: 🟩 SUCCESS

+-----------------------+---------------------+--------------------------------------------+--------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name         | caller_address                             | fx_paths                                                                             | action_ids                                                         |   bip   | tx_index |
+-----------------------+---------------------+--------------------------------------------+--------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20250212-v3-mev-capture-hook/MevCaptureHook/addMevTaxExemptSenders(address[])        | 0x17024432bfda7b943932633322c0dcc89b380311f26a3544ccda6eb5cd6bef65 | BIP-789 |    0     |
|                       |                     |                                            | 20250212-v3-mev-capture-hook/MevCaptureHook/removeMevTaxExemptSenders(address[])     | 0x2fcebd2fe4f213bb084e9d41e9b8a1ceb8b2d2916ff032c93f556deb984a9ff6 |         |          |
|                       |                     |                                            | 20250212-v3-mev-capture-hook/MevCaptureHook/disableMevTax()                          | 0xbda3401247f7a4661e06d58b77fb710e3531091c0b521d24a744f58933745e18 |         |          |
|                       |                     |                                            | 20250212-v3-mev-capture-hook/MevCaptureHook/enableMevTax()                           | 0xfb223c0dc293c599b2e25e2e5a94f569741ec76e268779a3e2326ab5b41daed0 |         |          |
|                       |                     |                                            | 20250212-v3-mev-capture-hook/MevCaptureHook/setDefaultMevTaxMultiplier(uint256)      | 0x772cd983d0b4a8e717b61ba3beaaff7b352f1c220763e3ac36c91d7850d81edc |         |          |
|                       |                     |                                            | 20250212-v3-mev-capture-hook/MevCaptureHook/setDefaultMevTaxThreshold(uint256)       | 0xa8ef455da97a35724b2fb844ad06e34b821bbc8df26a448eec44e9dedd96bfe9 |         |          |
|                       |                     |                                            | 20250212-v3-mev-capture-hook/MevCaptureHook/setMaxMevSwapFeePercentage(uint256)      | 0x89ca43e71ae2fb8e3f4752bca2af32b2423de7071aa88e76302aa11910ecea32 |         |          |
|                       |                     |                                            | 20250212-v3-mev-capture-hook/MevCaptureHook/setPoolMevTaxMultiplier(address,uint256) | 0xe8f2291394946ee5c5f23ca57ef6f232e07bf6c66fe01c5f2adfc012dde326fd |         |          |
|                       |                     |                                            | 20250212-v3-mev-capture-hook/MevCaptureHook/setPoolMevTaxThreshold(address,uint256)  | 0x235aeae017d90d17ad71f80bcff4fed15fff4c242382e58f8fe01dad43a8d585 |         |          |
+-----------------------+---------------------+--------------------------------------------+--------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

@Xeonus Xeonus changed the title [BIP-XXX] Grant Maxis Parameter Control on the MEV Tax Hook [BIP-789] Grant Maxis Parameter Control on the MEV Tax Hook Feb 26, 2025
gosuto-inzasheru
gosuto-inzasheru approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches prop

@gosuto-inzasheru gosuto-inzasheru merged commit deef43e into main Mar 3, 2025
2 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the bip-xxx-grant-maxis-parameter-control-mev-tax-hook branch March 3, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosuto-inzasheru gosuto-inzasheru gosuto-inzasheru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xeonus @gosuto-inzasheru