Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_reward_USDC_rsETH_gauge #770

Merged
merged 7 commits into from
Jan 25, 2024
Merged

add_reward_USDC_rsETH_gauge #770

merged 7 commits into from
Jan 25, 2024

Conversation

Zen-Maxi
Copy link
Collaborator

@Zen-Maxi Zen-Maxi commented Jan 23, 2024

Adds USDC as reward for rsETH/wETH gauge on zkEVM.
Copy link
Contributor

BIP validation results for file MaxiOps/01-2024/add_reward_USDC_rsETH_gauge.json:
Commit: 8ef1e128232a068842b4bed2bb52de997eddf915

+-------------------------------+-----------------------------------------------------------------------------------+
|           Validator           |                                       Result                                      |
+-------------------------------+-----------------------------------------------------------------------------------+
|     validate_contains_msig    |                                         OK                                        |
| validate_msig_in_address_book |                                         OK                                        |
|    validate_chain_specified   |                                         OK                                        |
|     validate_file_has_bip     | No BIP number found in file path MaxiOps/01-2024/add_reward_USDC_rsETH_gauge.json |
|  validate_path_has_weekly_dir | File MaxiOps/01-2024/add_reward_USDC_rsETH_gauge.json has has no YYYY-W## in path |
+-------------------------------+-----------------------------------------------------------------------------------+

Copy link
Contributor

FILENAME: MaxiOps/01-2024/add_reward_USDC_rsETH_gauge.json
MULTISIG: multisigs/feesManager (zkevm:0xB59Ab49CA8d064E645Bf2c546d9FE6d1d4147a09)
COMMIT: 8ef1e128232a068842b4bed2bb52de997eddf915
CHAIN(S): zkevm

+---------------+-----------------------------------------------------------------------------------------------------------------+---------+--------------------------------------------------------------------------------------------------------------------------------------------------------+--------------+------------+
| fx_name       | to                                                                                                              |   value | inputs                                                                                                                                                 | bip_number   | tx_index   |
+===============+=================================================================================================================+=========+========================================================================================================================================================+==============+============+
| performAction | 0xb9aD3466cdd42015cc05d4804DC68D562b6a2065 (20221124-authorizer-adaptor-entrypoint/AuthorizerAdaptorEntrypoint) |       0 | {                                                                                                                                                      | N/A          | N/A        |
|               |                                                                                                                 |         |   "target": [                                                                                                                                          |              |            |
|               |                                                                                                                 |         |     "0xA442C9cB6Fafb6Fb2a722A1BAa54f9b8ff0A55D3 (N/A) "                                                                                                |              |            |
|               |                                                                                                                 |         |   ],                                                                                                                                                   |              |            |
|               |                                                                                                                 |         |   "data": "0xe8de0d4d000000000000000000000000a8ce8aee21bc2a48a5ef670afcc9274c7bbbc0350000000000000000000000002f1901f2a82fcc3ee9010b809938816b3b06fa6a" |              |            |
|               |                                                                                                                 |         | }                                                                                                                                                      |              |            |
+---------------+-----------------------------------------------------------------------------------------------------------------+---------+--------------------------------------------------------------------------------------------------------------------------------------------------------+--------------+------------+

Zen-Maxi and others added 3 commits January 23, 2024 00:54
Copy link
Contributor

BIP validation results for file MaxiOps/01-2024/MOPS-001/setRecipientList_zkEVM_USDC_rsETH.json:
Commit: bc7e25122b88a433febef9521fb2a10e9efd2e77

+-------------------------------+--------------------------------------------------------------------------------------------------+
|           Validator           |                                              Result                                              |
+-------------------------------+--------------------------------------------------------------------------------------------------+
|     validate_contains_msig    |                                                OK                                                |
| validate_msig_in_address_book |                                                OK                                                |
|    validate_chain_specified   |                                                OK                                                |
|     validate_file_has_bip     | No BIP number found in file path MaxiOps/01-2024/MOPS-001/setRecipientList_zkEVM_USDC_rsETH.json |
|  validate_path_has_weekly_dir | File MaxiOps/01-2024/MOPS-001/setRecipientList_zkEVM_USDC_rsETH.json has has no YYYY-W## in path |
+-------------------------------+--------------------------------------------------------------------------------------------------+

BIP validation results for file MaxiOps/01-2024/add_reward_USDC_rsETH_gauge.json:
Commit: bc7e25122b88a433febef9521fb2a10e9efd2e77

+-------------------------------+-----------------------------------------------------------------------------------+
|           Validator           |                                       Result                                      |
+-------------------------------+-----------------------------------------------------------------------------------+
|     validate_contains_msig    |                                         OK                                        |
| validate_msig_in_address_book |                                         OK                                        |
|    validate_chain_specified   |                                         OK                                        |
|     validate_file_has_bip     | No BIP number found in file path MaxiOps/01-2024/add_reward_USDC_rsETH_gauge.json |
|  validate_path_has_weekly_dir | File MaxiOps/01-2024/add_reward_USDC_rsETH_gauge.json has has no YYYY-W## in path |
+-------------------------------+-----------------------------------------------------------------------------------+

Copy link
Contributor

FILENAME: MaxiOps/01-2024/MOPS-001/setRecipientList_zkEVM_USDC_rsETH.json
MULTISIG: multisigs/feesManager (zkevm:0xB59Ab49CA8d064E645Bf2c546d9FE6d1d4147a09)
COMMIT: bc7e25122b88a433febef9521fb2a10e9efd2e77
CHAIN(S): zkevm

+------------------+------------------------------------------------------------------------------------------------------+---------+---------------------------------------------------------+--------------+------------+
| fx_name          | to                                                                                                   |   value | inputs                                                  | bip_number   | tx_index   |
+==================+======================================================================================================+=========+=========================================================+==============+============+
| setRecipientList | 0x2F1901f2A82fcC3Ee9010b809938816B3b06FA6A (maxiKeepers/gaugeRewardsInjectors/usdc_rewards_injector) |       0 | {                                                       | N/A          | N/A        |
|                  |                                                                                                      |         |   "gaugeAddresses": [                                   |              |            |
|                  |                                                                                                      |         |     "0xA442C9cB6Fafb6Fb2a722A1BAa54f9b8ff0A55D3 (N/A) " |              |            |
|                  |                                                                                                      |         |   ],                                                    |              |            |
|                  |                                                                                                      |         |   "amountsPerPeriod": "[1500000000]",                   |              |            |
|                  |                                                                                                      |         |   "maxPeriods": "[8]"                                   |              |            |
|                  |                                                                                                      |         | }                                                       |              |            |
+------------------+------------------------------------------------------------------------------------------------------+---------+---------------------------------------------------------+--------------+------------+

FILENAME: MaxiOps/01-2024/add_reward_USDC_rsETH_gauge.json
MULTISIG: multisigs/feesManager (zkevm:0xB59Ab49CA8d064E645Bf2c546d9FE6d1d4147a09)
COMMIT: bc7e25122b88a433febef9521fb2a10e9efd2e77
CHAIN(S): zkevm

+---------------+-----------------------------------------------------------------------------------------------------------------+---------+--------------------------------------------------------------------------------------------------------------------------------------------------------+--------------+------------+
| fx_name       | to                                                                                                              |   value | inputs                                                                                                                                                 | bip_number   | tx_index   |
+===============+=================================================================================================================+=========+========================================================================================================================================================+==============+============+
| performAction | 0xb9aD3466cdd42015cc05d4804DC68D562b6a2065 (20221124-authorizer-adaptor-entrypoint/AuthorizerAdaptorEntrypoint) |       0 | {                                                                                                                                                      | N/A          | N/A        |
|               |                                                                                                                 |         |   "target": [                                                                                                                                          |              |            |
|               |                                                                                                                 |         |     "0xA442C9cB6Fafb6Fb2a722A1BAa54f9b8ff0A55D3 (N/A) "                                                                                                |              |            |
|               |                                                                                                                 |         |   ],                                                                                                                                                   |              |            |
|               |                                                                                                                 |         |   "data": "0xe8de0d4d000000000000000000000000a8ce8aee21bc2a48a5ef670afcc9274c7bbbc0350000000000000000000000002f1901f2a82fcc3ee9010b809938816b3b06fa6a" |              |            |
|               |                                                                                                                 |         | }                                                                                                                                                      |              |            |
+---------------+-----------------------------------------------------------------------------------------------------------------+---------+--------------------------------------------------------------------------------------------------------------------------------------------------------+--------------+------------+

Copy link
Contributor

BIP validation results for file MaxiOps/01-2024/MOPS-002/setRecipientList_zkEVM_USDC_rsETH.json:
Commit: 31cbb485e78f74eff63e1d7e4436feb581103031

+-------------------------------+--------------------------------------------------------------------------------------------------+
|           Validator           |                                              Result                                              |
+-------------------------------+--------------------------------------------------------------------------------------------------+
|     validate_contains_msig    |                                                OK                                                |
| validate_msig_in_address_book |                                                OK                                                |
|    validate_chain_specified   |                                                OK                                                |
|     validate_file_has_bip     | No BIP number found in file path MaxiOps/01-2024/MOPS-002/setRecipientList_zkEVM_USDC_rsETH.json |
|  validate_path_has_weekly_dir | File MaxiOps/01-2024/MOPS-002/setRecipientList_zkEVM_USDC_rsETH.json has has no YYYY-W## in path |
+-------------------------------+--------------------------------------------------------------------------------------------------+

BIP validation results for file MaxiOps/01-2024/add_reward_USDC_rsETH_gauge.json:
Commit: 31cbb485e78f74eff63e1d7e4436feb581103031

+-------------------------------+-----------------------------------------------------------------------------------+
|           Validator           |                                       Result                                      |
+-------------------------------+-----------------------------------------------------------------------------------+
|     validate_contains_msig    |                                         OK                                        |
| validate_msig_in_address_book |                                         OK                                        |
|    validate_chain_specified   |                                         OK                                        |
|     validate_file_has_bip     | No BIP number found in file path MaxiOps/01-2024/add_reward_USDC_rsETH_gauge.json |
|  validate_path_has_weekly_dir | File MaxiOps/01-2024/add_reward_USDC_rsETH_gauge.json has has no YYYY-W## in path |
+-------------------------------+-----------------------------------------------------------------------------------+

Copy link
Contributor

FILENAME: MaxiOps/01-2024/MOPS-002/setRecipientList_zkEVM_USDC_rsETH.json
MULTISIG: multisigs/feesManager (zkevm:0xB59Ab49CA8d064E645Bf2c546d9FE6d1d4147a09)
COMMIT: 31cbb485e78f74eff63e1d7e4436feb581103031
CHAIN(S): zkevm

+------------------+------------------------------------------------------------------------------------------------------+---------+---------------------------------------------------------+--------------+------------+
| fx_name          | to                                                                                                   |   value | inputs                                                  | bip_number   | tx_index   |
+==================+======================================================================================================+=========+=========================================================+==============+============+
| setRecipientList | 0x2F1901f2A82fcC3Ee9010b809938816B3b06FA6A (maxiKeepers/gaugeRewardsInjectors/usdc_rewards_injector) |       0 | {                                                       | N/A          | N/A        |
|                  |                                                                                                      |         |   "gaugeAddresses": [                                   |              |            |
|                  |                                                                                                      |         |     "0xA442C9cB6Fafb6Fb2a722A1BAa54f9b8ff0A55D3 (N/A) " |              |            |
|                  |                                                                                                      |         |   ],                                                    |              |            |
|                  |                                                                                                      |         |   "amountsPerPeriod": "[1500000000]",                   |              |            |
|                  |                                                                                                      |         |   "maxPeriods": "[8]"                                   |              |            |
|                  |                                                                                                      |         | }                                                       |              |            |
+------------------+------------------------------------------------------------------------------------------------------+---------+---------------------------------------------------------+--------------+------------+

FILENAME: MaxiOps/01-2024/add_reward_USDC_rsETH_gauge.json
MULTISIG: multisigs/feesManager (zkevm:0xB59Ab49CA8d064E645Bf2c546d9FE6d1d4147a09)
COMMIT: 31cbb485e78f74eff63e1d7e4436feb581103031
CHAIN(S): zkevm

+---------------+-----------------------------------------------------------------------------------------------------------------+---------+--------------------------------------------------------------------------------------------------------------------------------------------------------+--------------+------------+
| fx_name       | to                                                                                                              |   value | inputs                                                                                                                                                 | bip_number   | tx_index   |
+===============+=================================================================================================================+=========+========================================================================================================================================================+==============+============+
| performAction | 0xb9aD3466cdd42015cc05d4804DC68D562b6a2065 (20221124-authorizer-adaptor-entrypoint/AuthorizerAdaptorEntrypoint) |       0 | {                                                                                                                                                      | N/A          | N/A        |
|               |                                                                                                                 |         |   "target": [                                                                                                                                          |              |            |
|               |                                                                                                                 |         |     "0xA442C9cB6Fafb6Fb2a722A1BAa54f9b8ff0A55D3 (N/A) "                                                                                                |              |            |
|               |                                                                                                                 |         |   ],                                                                                                                                                   |              |            |
|               |                                                                                                                 |         |   "data": "0xe8de0d4d000000000000000000000000a8ce8aee21bc2a48a5ef670afcc9274c7bbbc0350000000000000000000000002f1901f2a82fcc3ee9010b809938816b3b06fa6a" |              |            |
|               |                                                                                                                 |         | }                                                                                                                                                      |              |            |
+---------------+-----------------------------------------------------------------------------------------------------------------+---------+--------------------------------------------------------------------------------------------------------------------------------------------------------+--------------+------------+

@Tritium-VLK
Copy link
Contributor

@Zen-Maxi do we need to add reward token?

Copy link
Contributor

@Tritium-VLK Tritium-VLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need add reward token?

@Tritium-VLK Tritium-VLK self-requested a review January 23, 2024 02:58
@Tritium-VLK
Copy link
Contributor

Do we need add reward token?

nevermind it's right there :)

@Tritium-VLK Tritium-VLK merged commit f20a1db into main Jan 25, 2024
@Tritium-VLK Tritium-VLK deleted the add_reward_USDC_rsETH_gauge branch January 25, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants