Infrastructure for Kolmogorov-Smirnov tests, (tested!) methods for sampling with replacement, and changes to include guards #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, the scope of this PR exceeded my original plans.
Incidental, but notable changes
I removed the include-guard pattern
and replaced it with
#pragma once
everywhere.Main changes
I added three functions to
RandBLAS/util.hh
:I added a file
This file is where we'll put code that's used to construct our statistical tests. Conceptually distinct parts of the file:
log_binomial_coefficient
.repeated_fisher_yates
(our function for sampling uniformly from an index set without replacement). Note: I haven't implemented this test yet!I also added
Right now it only contains tests for sampling with replacement. It should also contain tests for sampling without replacement, where an empirical CDF for the hypergeometric distribution can be constructed from
repeated_fisher_yates
and the true CDF can be computed fromtest_basic_rng/rng_common.hh
.