Update macos-openmp GitHub actions workflow for macos-14 and higher #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macos-openmp CI build has been failing lately. The error occurrs when trying to build blaspp:
I'm pretty sure this stems from changes to the macos-latest GitHub Actions runner. When the failing builds install the LLVM toolchain, they report using llvm--18.1.5.arm64_sonoma.bottle.tar.gz and install to
/opt/homebrew/opt/llvm/
. Compare to the successful builds, which report using llvm--17.0.6_1.monterey.bottle.tar.gz and install to/usr/local/opt/llvm/
.I'm not sure if I have a fix at time of opening this PR. I'm only opening it now because I need to test potential fixes and actually run the actions.My suspicion was right. The CMake configuration lines for blaspp and RandBLAS explicitly set
/usr/local/opt/llvm/bin/clang++
and/usr/local/opt/llvm/bin/clang
for C++ and C compilers. These paths needed to be updated to reflect the new location of these compilers in the latest macos runner.Incidental changes
The macos-latest build showed compiler warnings about allocating dynamically-sized arrays on the stack. I've changed them to allocate on the heap (with
T* val = new T[size]
, as opposed toT val[size]
).