poetry: remove pendulum dependency #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laggron42
force-pushed
the
lagg/fix-docker-3.13
branch
from
153db6c to
514cea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455
Fork
fastapi-adminto remove pendulum dependency. This is needed as pendulum wheels are missing for 3.13 (see python-pendulum/pendulum#844), triggering a rebuild which needs rust to compile. Adding rust to our docker image would make it considerably slower and heavier, thus removing the dependency is easier.fastapi-adminuses pendulum for datetime filtering which we don't use. The poetry now points to our own fork. This fork may be used in the future to add some fixes that were not added to the original repo.