Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting FiniteType to support constructors with multiple arguments #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maxkurze1
Copy link

It took me a while, but I figured out the problems of my first approach (see #2).

I turned out that finite_surjective was used as part of computations which get stuck once they encounter an opaque term/lemma. So the solution was basically to redefine all lemma dependencies using nothing than transparent terms.

Now, we can finally derive FiniteType type classes for more complex (possibly even all finite) Inductive types.

@maxkurze1 maxkurze1 force-pushed the multi-arg-finite-type branch from 6c0f9c9 to 4c84f8f Compare November 9, 2024 11:49
@spacefrogg
Copy link
Collaborator

You've created a dependency cycle (have a look at the CI output).

@maxkurze1
Copy link
Author

Oh, I am sorry for bothering you, that commit is still a WIP. I just wanted to have it persisted in git. I didn't quite remember there was already a PR for this branch. Anyway; you can notice these commits by their meaningless commit names ^^. Have a nice day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants