otelcol.connector.servicegraph: update default store ttl value (grafa…

…na#5941) * otelcol.connector.servicegraph: update default store ttl value Signed-off-by: Robbie Lankford <[email protected]> * update test --------- Signed-off-by: Robbie Lankford <[email protected]>
BarunKGP · Feb 20, 2024 · 866bc45 · 866bc45
1 parent 617e7d1
commit 866bc45
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -55,6 +55,8 @@ Main (unreleased)
 
 - Fixes `loki.source.docker` a behavior that synced an incomplete list of targets to the tailer manager. (@FerdinandvHagen)
 
+- Fixes `otelcol.connector.servicegraph` store ttl default value from 2ms to 2s. (@rlankfo)
+
 ### Other changes
 
 - Bump github.com/IBM/sarama from v1.41.2 to v1.42.1

diff --git a/component/otelcol/connector/servicegraph/servicegraph.go b/component/otelcol/connector/servicegraph/servicegraph.go
@@ -91,7 +91,7 @@ var DefaultArguments = Arguments{
 	Dimensions: []string{},
 	Store: StoreConfig{
 		MaxItems: 1000,
-		TTL:      2 * time.Millisecond,
+		TTL:      2 * time.Second,
 	},
 	CacheLoop:           1 * time.Minute,
 	StoreExpirationLoop: 2 * time.Second,

diff --git a/component/otelcol/connector/servicegraph/servicegraph_test.go b/component/otelcol/connector/servicegraph/servicegraph_test.go
@@ -44,7 +44,7 @@ func TestArguments_UnmarshalRiver(t *testing.T) {
 				Dimensions: []string{},
 				Store: servicegraphprocessor.StoreConfig{
 					MaxItems: 1000,
-					TTL:      2 * time.Millisecond,
+					TTL:      2 * time.Second,
 				},
 				CacheLoop:           1 * time.Minute,
 				StoreExpirationLoop: 2 * time.Second,

diff --git a/docs/sources/flow/reference/components/otelcol.connector.servicegraph.md b/docs/sources/flow/reference/components/otelcol.connector.servicegraph.md
@@ -135,7 +135,7 @@ The `store` block configures the in-memory store for spans.
 Name | Type | Description | Default | Required
 ---- | ---- | ----------- | ------- | --------
 `max_items` | `number` | Maximum number of items to keep in the store. | `1000` | no
-`ttl` | `duration` | The time to live for spans in the store. | `"2ms"` | no
+`ttl` | `duration` | The time to live for spans in the store. | `"2s"` | no
 
 ### output block
 
@@ -238,4 +238,4 @@ connection work correctly. Refer to the linked documentation for more details.
 
 {{% /admonition %}}
 
-<!-- END GENERATED COMPATIBLE COMPONENTS -->
+<!-- END GENERATED COMPATIBLE COMPONENTS -->