Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated app facing package and implemented isPresent() in example project #205

Conversation

TimHoogstrate
Copy link
Contributor

@TimHoogstrate TimHoogstrate commented Feb 16, 2024

Implements: (#194) and updates main package with new platform interface 3.x.x and added isPresent to the example project.

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@TimHoogstrate TimHoogstrate changed the title updated main package and implemented isPresent in example project Updated app facing package and implemented isPresent() in example project Feb 16, 2024
@TimHoogstrate TimHoogstrate marked this pull request as ready for review February 16, 2024 09:01
geocoding/lib/geocoding.dart Outdated Show resolved Hide resolved
geocoding/lib/geocoding.dart Outdated Show resolved Hide resolved
geocoding/lib/geocoding.dart Outdated Show resolved Hide resolved
geocoding/lib/geocoding.dart Outdated Show resolved Hide resolved
geocoding/lib/geocoding.dart Outdated Show resolved Hide resolved
geocoding/lib/geocoding.dart Outdated Show resolved Hide resolved
Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvanbeusekom mvanbeusekom merged commit ed2987d into Baseflow:main Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants