Rework (sound) effects of valuable tactical missiles (FAForever#5961)

projectiles/AIFMissileSerpentine01/AIFMissileSerpentine01_script.lua

@@ -1,3 +1,26 @@
+
+--******************************************************************************************************
+--** Copyright (c) 2024 FAForever
+--**
+--** Permission is hereby granted, free of charge, to any person obtaining a copy
+--** of this software and associated documentation files (the "Software"), to deal
+--** in the Software without restriction, including without limitation the rights
+--** to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+--** copies of the Software, and to permit persons to whom the Software is
+--** furnished to do so, subject to the following conditions:
+--**
+--** The above copyright notice and this permission notice shall be included in all
+--** copies or substantial portions of the Software.
+--**
+--** THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+--** IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+--** FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+--** AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+--** LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+--** OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+--** SOFTWARE.
+--******************************************************************************************************
+
 local AMissileSerpentineProjectile = import("/lua/aeonprojectiles.lua").AMissileSerpentineProjectile
 
 --- Used by ual0111 (T2 Mobile Missile Launcher)

projectiles/AIFMissileSerpentine02/AIFMissileSerpentine02_proj.bp

@@ -65,4 +65,5 @@ ProjectileBlueprint {
         MaxZigZag = 4,
         ZigZagFrequency = 0.4,
     },
+    StrategicIconName = '/textures/ui/common/game/strategicicons/icon_tactical_missile.dds',
 }

projectiles/AIFMissileSerpentine02/AIFMissileSerpentine02_script.lua

@@ -1,10 +1,56 @@
+--******************************************************************************************************
+--** Copyright (c) 2024 FAForever
+--**
+--** Permission is hereby granted, free of charge, to any person obtaining a copy
+--** of this software and associated documentation files (the "Software"), to deal
+--** in the Software without restriction, including without limitation the rights
+--** to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+--** copies of the Software, and to permit persons to whom the Software is
+--** furnished to do so, subject to the following conditions:
+--**
+--** The above copyright notice and this permission notice shall be included in all
+--** copies or substantial portions of the Software.
+--**
+--** THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+--** IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+--** FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+--** AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+--** LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+--** OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+--** SOFTWARE.
+--******************************************************************************************************
+
 local AMissileSerpentineProjectile = import("/lua/aeonprojectiles.lua").AMissileSerpentineProjectile
+local AMissileSerpentineProjectileOnImpact = AMissileSerpentineProjectile.OnImpact
+
+local EffectTemplate = import("/lua/effecttemplates.lua")
 
 --- Used by UAS0304 (T3 Stategic Missile Submarine)
 ---@class AIFMissileSerpentine02 : AMissileSerpentineProjectile
 AIFMissileSerpentine02 = ClassProjectile(AMissileSerpentineProjectile) {
+    FxImpactUnit = EffectTemplate.AMissileHit02,
+    FxImpactProp = EffectTemplate.AMissileHit02,
+    FxImpactLand = EffectTemplate.AMissileHit02,
+
+    FxLandHitScale = 1.65,
+    FxPropHitScale = 1.65,
+    FxUnitHitScale = 1.65,
     FxWaterHitScale = 1.65,
 
     TerminalZigZagMultiplier = 0.5,
+
+    --- Called by the engine when the projectile impacts something
+    ---@param self Projectile
+    ---@param targetType string
+    ---@param targetEntity Unit | Prop
+    OnImpact = function(self, targetType, targetEntity)
+        AMissileSerpentineProjectileOnImpact(self, targetType, targetEntity)
+
+        local army = self.Army
+
+        -- create light flashes
+        CreateLightParticleIntel(self, -1, army, 8, 2, 'flare_lens_add_02', 'ramp_green_02')
+        CreateLightParticleIntel(self, -1, army, 12, 4, 'flare_lens_add_02', 'ramp_green_12')
+    end
 }
 TypeClass = AIFMissileSerpentine02

projectiles/AIFMissileSerpentine03/AIFMissileSerpentine03_Script.lua

@@ -1,3 +1,26 @@
+
+--******************************************************************************************************
+--** Copyright (c) 2024 FAForever
+--**
+--** Permission is hereby granted, free of charge, to any person obtaining a copy
+--** of this software and associated documentation files (the "Software"), to deal
+--** in the Software without restriction, including without limitation the rights
+--** to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+--** copies of the Software, and to permit persons to whom the Software is
+--** furnished to do so, subject to the following conditions:
+--**
+--** The above copyright notice and this permission notice shall be included in all
+--** copies or substantial portions of the Software.
+--**
+--** THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+--** IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+--** FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+--** AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+--** LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+--** OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+--** SOFTWARE.
+--******************************************************************************************************
+
 local AMissileSerpentine02Projectile = import("/lua/aeonprojectiles.lua").AMissileSerpentine02Projectile
 
 --- Serpentine Missile 03 : XAS0306

projectiles/AIFMissileTactical01/AIFMissileTactical01_proj.bp

@@ -67,5 +67,5 @@ ProjectileBlueprint {
         MaxZigZag = 4,
         ZigZagFrequency = 0.2,
     },
-    StrategicIconName = '/textures/ui/common/game/strategicicons/icon_tactical_missile.png',
+    StrategicIconName = '/textures/ui/common/game/strategicicons/icon_tactical_missile.dds',
 }

projectiles/AIFMissileTactical02/AIFMissileTactical02_Script.lua

@@ -1,3 +1,26 @@
+
+--******************************************************************************************************
+--** Copyright (c) 2024 FAForever
+--**
+--** Permission is hereby granted, free of charge, to any person obtaining a copy
+--** of this software and associated documentation files (the "Software"), to deal
+--** in the Software without restriction, including without limitation the rights
+--** to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+--** copies of the Software, and to permit persons to whom the Software is
+--** furnished to do so, subject to the following conditions:
+--**
+--** The above copyright notice and this permission notice shall be included in all
+--** copies or substantial portions of the Software.
+--**
+--** THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+--** IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+--** FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+--** AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+--** LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+--** OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+--** SOFTWARE.
+--******************************************************************************************************
+
 local AMissileSerpentineProjectile = import("/lua/aeonprojectiles.lua").AMissileSerpentineProjectile
 
 -- Aeon Land-Based Tactical Missile

projectiles/AIFMissileTactical02/AIFMissileTactical02_proj.bp

@@ -2,12 +2,12 @@ ProjectileBlueprint {
     Audio = {
         Impact = Sound {
             Bank = 'Impacts',
-            Cue = 'AEON_Expl_Med_Impact',
+            Cue = 'AEON_Expl_Lrg_Naval',
             LodCutoff = 'Weapon_LodCutoff',
         },
         ImpactTerrain = Sound {
             Bank = 'Impacts',
-            Cue = 'Impact_Land_Gen_AEON',
+            Cue = 'AEON_Expl_Lrg_Naval',
             LodCutoff = 'Weapon_LodCutoff',
         },
         ImpactWater = Sound {

projectiles/CIFMissileTactical02/CIFMissileTactical02_Script.lua

@@ -1,4 +1,35 @@
+--******************************************************************************************************
+--** Copyright (c) 2024 FAForever
+--**
+--** Permission is hereby granted, free of charge, to any person obtaining a copy
+--** of this software and associated documentation files (the "Software"), to deal
+--** in the Software without restriction, including without limitation the rights
+--** to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+--** copies of the Software, and to permit persons to whom the Software is
+--** furnished to do so, subject to the following conditions:
+--**
+--** The above copyright notice and this permission notice shall be included in all
+--** copies or substantial portions of the Software.
+--**
+--** THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+--** IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+--** FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+--** AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+--** LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+--** OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+--** SOFTWARE.
+--******************************************************************************************************
+
 local CLOATacticalMissileProjectile = import("/lua/cybranprojectiles.lua").CLOATacticalMissileProjectile
+local CLOATacticalMissileProjectileOnImpact = CLOATacticalMissileProjectile.OnImpact
+local CLOATacticalMissileProjectileOnCreate = CLOATacticalMissileProjectile.OnCreate
+local CLOATacticalMissileProjectileOnExitWater = CLOATacticalMissileProjectile.OnExitWater
+
+-- upvalue scope for performance
+local Random = Random
+local CreateLightParticleIntel = CreateLightParticleIntel
+
+local TableRandom = table.random
 
 --- URS0304 : cybran nuke sub
 --- Cybran "Loa" Tactical Missile, structure unit and sub launched variant of this projectile,
@@ -10,14 +41,37 @@ CIFMissileTactical02 = ClassProjectile(CLOATacticalMissileProjectile) {
 
     ---@param self CIFMissileTactical02
     OnCreate = function(self)
-        CLOATacticalMissileProjectile.OnCreate(self)
+        CLOATacticalMissileProjectileOnCreate(self)
         self.MoveThread = self.Trash:Add(ForkThread(self.MovementThread, self))
     end,
 
     ---@param self CIFMissileTactical02
     OnExitWater = function(self)
-        CLOATacticalMissileProjectile.OnExitWater(self)
+        CLOATacticalMissileProjectileOnExitWater(self)
         self:SetDestroyOnWater(true)
     end,
+
+    --- Called by the engine when the projectile impacts something
+    ---@param self CIFMissileTactical02
+    ---@param targetType string
+    ---@param targetEntity Unit | Prop
+    OnImpact = function(self, targetType, targetEntity)
+        CLOATacticalMissileProjectileOnImpact(self, targetType, targetEntity)
+
+        local army = self.Army
+
+        -- create light flashes
+        CreateLightParticleIntel(self, -1, army, 5, 12, 'glow_03', 'ramp_red_06')
+        CreateLightParticleIntel(self, -1, army, 5, 22, 'glow_03', 'ramp_antimatter_02')
+
+        -- create flying and burning debris for the child projectiles
+        local vx, _, vz = self:GetVelocity()
+        for k = 1, self.ChildCount do
+            local blueprint = TableRandom(self.DebrisBlueprints)
+            local pvx = 0.5 * (vx + Random() - 0.5)
+            local pvz = 0.5 * (vz + Random() - 0.5)
+            self:CreateProjectile(blueprint, 0, 0.2, 0, pvx, 0.75, pvz)
+        end
+    end
 }
 TypeClass = CIFMissileTactical02

projectiles/CIFMissileTactical02/CIFMissileTactical02_proj.bp

@@ -1,13 +1,13 @@
 ProjectileBlueprint {
     Audio = {
         Impact = Sound {
-            Bank = 'Impacts',
-            Cue = 'CYB_Expl_Med_Impact',
+            Bank = 'Explosions',
+            Cue = 'Explosion_Bomb',
             LodCutoff = 'Weapon_LodCutoff',
         },
         ImpactTerrain = Sound {
-            Bank = 'Impacts',
-            Cue = 'Impact_Land_Gen_CYBRAN',
+            Bank = 'Explosions',
+            Cue = 'Explosion_Bomb',
             LodCutoff = 'Weapon_LodCutoff',
         },
         ImpactWater = Sound {
@@ -63,4 +63,5 @@ ProjectileBlueprint {
         ZigZagFrequency = 1,
         MaxZigZag = 1,
     },
+    StrategicIconName = '/textures/ui/common/game/strategicicons/icon_tactical_missile.dds',
 }

projectiles/CIFMissileTactical03/CIFMissileTactical03_Script.lua

@@ -45,7 +45,7 @@ CIFMissileTactical03 = ClassProjectile(CLOATacticalMissileProjectile) {
     end,
 
     --- Called by the engine when the projectile impacts something
-    ---@param self Projectile
+    ---@param self CIFMissileTactical02
     ---@param targetType string
     ---@param targetEntity Unit | Prop
     OnImpact = function(self, targetType, targetEntity)
@@ -59,7 +59,7 @@ CIFMissileTactical03 = ClassProjectile(CLOATacticalMissileProjectile) {
 
         -- create flying and burning debris for the child projectiles
         local vx, _, vz = self:GetVelocity()
-        for k = 1, 3 do
+        for k = 1, self.ChildCount do
             local blueprint = TableRandom(self.DebrisBlueprints)
             local pvx = 0.5 * (vx + Random() - 0.5)
             local pvz = 0.5 * (vz + Random() - 0.5)

projectiles/CIFMissileTactical03/CIFMissileTactical03_proj.bp

@@ -68,5 +68,5 @@ ProjectileBlueprint {
         ZigZagFrequency = 1,
         MaxZigZag = 1,
     },
-    StrategicIconName = '/textures/ui/common/game/strategicicons/icon_tactical_missile.png',
+    StrategicIconName = '/textures/ui/common/game/strategicicons/icon_tactical_missile.dds',
 }

projectiles/SIFLaanseTacticalMissile04/SIFLaanseTacticalMissile04_proj.bp

@@ -68,5 +68,5 @@ ProjectileBlueprint {
         ZigZagFrequency = 1,
         MaxZigZag = 1,
     },
-    StrategicIconName = '/textures/ui/common/game/strategicicons/icon_tactical_missile.png',
+    StrategicIconName = '/textures/ui/common/game/strategicicons/icon_tactical_missile.dds',
 }

projectiles/SIFLaanseTacticalMissileCDR/SIFLaanseTacticalMissileCDR_proj.bp

@@ -66,4 +66,5 @@ ProjectileBlueprint {
         ZigZagFrequency = 1,
         MaxZigZag = 1
     },
+    StrategicIconName = '/textures/ui/common/game/strategicicons/icon_tactical_missile.dds',
 }

projectiles/SIFLaanseTacticalMissileCDR/SIFLaanseTacticalMissileCDR_script.lua

@@ -1,6 +1,6 @@
 
 --******************************************************************************************************
---** Copyright (c) 2022  Willem 'Jip' Wijnia
+--** Copyright (c) 2024 FAForever
 --**
 --** Permission is hereby granted, free of charge, to any person obtaining a copy
 --** of this software and associated documentation files (the "Software"), to deal
@@ -22,6 +22,10 @@
 --******************************************************************************************************
 
 local SLaanseTacticalMissile = import("/lua/seraphimprojectiles.lua").SLaanseTacticalMissile
+local SLaanseTacticalMissileOnImpact = SLaanseTacticalMissile.OnImpact
+local SLaanseTacticalMissileOnCreate = SLaanseTacticalMissile.OnCreate
+local SLaanseTacticalMissileOnExitWater = SLaanseTacticalMissile.OnExitWater
+
 local TacticalMissileComponent = import('/lua/sim/DefaultProjectiles.lua').TacticalMissileComponent
 
 --- Used by XSL0001
@@ -45,7 +49,7 @@ SIFLaanseTacticalMissileCDR = ClassProjectile(SLaanseTacticalMissile, TacticalMi
     ---@param self SIFLaanseTacticalMissileCDR
     ---@param inWater boolean
     OnCreate = function(self, inWater)
-        SLaanseTacticalMissile.OnCreate(self)
+        SLaanseTacticalMissileOnCreate(self)
         if not inWater then
             self:SetDestroyOnWater(true)
         end
@@ -54,9 +58,23 @@ SIFLaanseTacticalMissileCDR = ClassProjectile(SLaanseTacticalMissile, TacticalMi
 
     ---@param self SIFLaanseTacticalMissileCDR
     OnExitWater = function(self)
-        SLaanseTacticalMissile.OnExitWater(self)
+        SLaanseTacticalMissileOnExitWater(self)
         self:SetDestroyOnWater(true)
     end,
+
+    --- Called by the engine when the projectile impacts something
+    ---@param self Projectile
+    ---@param targetType string
+    ---@param targetEntity Unit | Prop
+    OnImpact = function(self, targetType, targetEntity)
+        SLaanseTacticalMissileOnImpact(self, targetType, targetEntity)
+
+        local army = self.Army
+
+        -- create light flashes
+        CreateLightParticleIntel(self, -1, army, 6, 2, 'flare_lens_add_02', 'ramp_blue_build_spray')
+        CreateLightParticleIntel(self, -1, army, 10, 4, 'flare_lens_add_02', 'ramp_ser_11')
+    end
 }
 TypeClass = SIFLaanseTacticalMissileCDR
 

projectiles/SIFLaanseTacticalMissileSCU/SIFLaanseTacticalMissileSCU_proj.bp

@@ -66,4 +66,5 @@ ProjectileBlueprint {
         ZigZagFrequency = 1,
         MaxZigZag = 1
     },
+    StrategicIconName = '/textures/ui/common/game/strategicicons/icon_tactical_missile.dds',
 }