Skip to content

Commit

Permalink
setup: comment with TODO for bastille.conf check
Browse files Browse the repository at this point in the history
  • Loading branch information
@jdhg-orbiware
jdhg-orbiware committed Nov 24, 2024
1 parent 67234b2 commit 426d0fd
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions usr/local/share/bastille/setup.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
bastille_config="/usr/local/etc/bastille/bastille.conf"
. /usr/local/share/bastille/common.sh

# TODO: This not going to take effect since Bastille checks the file
# before running this subcommand. We will need to check an strategy.
if [ ! -f "${bastille_config}" ]; then
cp /usr/local/etc/bastille/bastille.conf.sample ${bastille_config}
fi
Expand Down

3 comments on commit 426d0fd

@tschettervictor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this file checked before this command?

@yaazkal
Copy link
Collaborator

@yaazkal yaazkal commented on 426d0fd Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tschettervictor the bastille command itself, here:

bastille/usr/local/bin/bastille

Line 36 in c8a2b3a

bastille_conf_check() {

@tschettervictor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could do a conditional command.

if [ “${2}” != “setup” ]; then
    bastille_conf_check
fi

Please sign in to comment.