Fix bastille0 loopback IPv6 support #727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foudfou
commented
Nov 3, 2024
usr/local/share/bastille/start.sh
Outdated
| ips=$(bastille config "${_jail}" get ip4.addr) | ||
| ips="${ips} $(bastille config "${_jail}" get ip6.addr)" | ||
| for ip in ${ips}; do | ||
| ip=$(printf "$ip" | sed -E 's,/[0-9]+,,') |
There was a problem hiding this comment.
pfctl -t jails -Tadd <IP>/<CIDR> actually adds the network, not the IP.
|
@foudfou this one has conflicts also. Please clean up so I can test. |
foudfou
force-pushed
the
loopback-ip6
branch
from
2cf7462 to
990bf94
Compare
|
@bmac2 rebased. |
foudfou
force-pushed
the
loopback-ip6
branch
from
2b2abe0 to
cdba7c6
Compare
|
@bmac2 rebased again 😁 |
|
@foudfou one more rebase please. Will try to get this one reviewed and merged before needing another rebase. :-) |
|
Sorry @bmac2 I won't be able to work on this for a while. Feel free to close. |
|
Closing as the content of this PR is included in #830 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that, for jails created with
<jails>pf table