begin moving functions to common.sh (top htop) #776
+87
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschettervictor
changed the title
|
why accepting |
That was already in the top and htop file. It works but you have to press CTRL+C to jump to the next one... |
|
I've now changed it to where the set_target_single function will only set the target, and the check_target_exists will only verify that it exists. With this, it is probably necessary to first set, then check existence, the check if TARGET is running (only needed for some commands) I've also modified it so htop and top now only accept one argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bmac2
This was a simple first task. Do you think something like this will work?