Emit a TokenRefreshFailedEvent when the automatic token refresh fails #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokabakaroni
force-pushed
the
token-refresh-failed-event
branch
from
dfebb51 to
9b2b56f
Compare
ahmednfwela
reviewed
Dec 9, 2024
| @@ -731,10 +731,12 @@ abstract class OidcUserManagerBase { | |||
| /// | |||
| /// An [OidcException] will be thrown if the server returns an error. | |||
| Future<OidcUser?> refreshToken({ | |||
| OidcToken? overrideToken, | |||
There was a problem hiding this comment.
I think the overrideToken is unnecessary here, as you said, shared code should go into a doRefreshToken method that's marked @protected
There was a problem hiding this comment.
Thanks for the suggestions, should be done.
rokabakaroni
force-pushed
the
token-refresh-failed-event
branch
from
6674e7e to
f2f425d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As in #120, I added the emission of a
OidcTokenRefreshFailedEventwhen thehandleTokenExpiringhandler fails.The
refreshTokencode was repeated inside the handler, so I substituted most of the code with a call to it (maybe I should have created a_refreshTokenmethod to not expose the newoverrideTokenoptional parameter to therefreshTokenmethod?).Type of Change