-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sets up Travis/Codecov + basic regression tests #21
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage ? 77.08%
=========================================
Files ? 2
Lines ? 48
Branches ? 0
=========================================
Hits ? 37
Misses ? 11
Partials ? 0 Continue to review full report at Codecov.
|
Ideally I'd also want to test that bad frames are being skipped as expected (#10 (comment)). However, I'm not sure if the files are GPL compliant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all this work, @IAlibay !
Looks all fine to me. What I didn’t understand was the question regarding licensing of data files. Can you explain what your concern is?
Sorry, what I meant was; is it ok to include the files that @rsexton2 added in #10 and #13 under the GPLv3 licence of propkatraj? (my understanding is that @rsexton2 is a member of your lab @orbeckst ?) (I think we usually check this in MDA before adding user contributed files, so I didn't want to make any assumptions here). |
All three sets of datafiles are fine to be included under GPLv3. Thanks for being very thorough. |
Towards #20
Changes made: