Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets up Travis/Codecov + basic regression tests #21

Merged
merged 15 commits into from
Jul 6, 2020

Conversation

IAlibay
Copy link
Collaborator

@IAlibay IAlibay commented Jul 4, 2020

Towards #20

Changes made:

  • Adds the required Travis & Codecov files
  • Adds a few basic regression tests
    • Note: the assumption here is that the MDA PDB writer is accurate & that propka 3.1 will give intended results when given a file (i.e. the tests only really test that the PDBs are being correctly passed and the correct data structure is generated).

@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@2abd91f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #21   +/-   ##
=========================================
  Coverage          ?   77.08%           
=========================================
  Files             ?        2           
  Lines             ?       48           
  Branches          ?        0           
=========================================
  Hits              ?       37           
  Misses            ?       11           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2abd91f...8878990. Read the comment docs.

@IAlibay
Copy link
Collaborator Author

IAlibay commented Jul 4, 2020

Ideally I'd also want to test that bad frames are being skipped as expected (#10 (comment)). However, I'm not sure if the files are GPL compliant.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all this work, @IAlibay !

Looks all fine to me. What I didn’t understand was the question regarding licensing of data files. Can you explain what your concern is?

@IAlibay
Copy link
Collaborator Author

IAlibay commented Jul 5, 2020

Thank you for all this work, @IAlibay !

Looks all fine to me. What I didn’t understand was the question regarding licensing of data files. Can you explain what your concern is?

Sorry, what I meant was; is it ok to include the files that @rsexton2 added in #10 and #13 under the GPLv3 licence of propkatraj? (my understanding is that @rsexton2 is a member of your lab @orbeckst ?)

(I think we usually check this in MDA before adding user contributed files, so I didn't want to make any assumptions here).

@orbeckst
Copy link
Member

orbeckst commented Jul 6, 2020

All three sets of datafiles are fine to be included under GPLv3.

Thanks for being very thorough.

@orbeckst orbeckst self-assigned this Jul 6, 2020
@orbeckst orbeckst merged commit e15b206 into Becksteinlab:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants