feat: bump amp to v3 #52
Draft
+129
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yokann
force-pushed
the
feat/bump-amp-v3
branch
from
2e977e0 to
b33e40f
Compare
Yokann
force-pushed
the
feat/bump-amp-v3
branch
from
b33e40f to
820cea4
Compare
Comment on lines
+13
to
+14
| private \Amp\DeferredFuture $ampDeferred; | ||
| private PromiseWrapper $promise; |
There was a problem hiding this comment.
could be readonly
There was a problem hiding this comment.
What are the pros of making it read-only? It's a private attribute.
| @@ -11,11 +11,9 @@ | |||
| */ | |||
| class PromiseWrapper implements Promise | |||
| { | |||
| /** @var \Amp\Promise */ | |||
| private $ampPromise; | |||
| private \Amp\Future $ampPromise; | |||
There was a problem hiding this comment.
Could be readonly now, and the getter removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMPHP use now Fiber via Revolt eventloop.
I made this PR to update the current AMPHP implementation of Tornado to this new version.
I don't think it's a good idea to keep both implementation of AMP (2.6 and 3.0)
Documentaion
https://amphp.org/upgrade
https://revolt.run/fundamentals