Fixes reagent grinder juicing. Again. #12034
Open
+80
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tsar-Salat
requested changes
Dec 14, 2024
There was a problem hiding this comment.
This is the third pr.
This needs to be unit tested, seeing as this has been merged two times already testing evidence kinda isnt enough.
This PR should include a unit test for processing an input into an output for grinders, testing that the grinder:
- Accepts the item(vegetable or fruit, whichever example grown food you want to use)
- Activates when used (proccall the machine if the mob using it is not doable)
- The output reagent, x, is between a minimum and maximum number
|
FUCK I FORGOT TO UNDO THE COMPILE OPTIONS |
|
I was about to make a new issue but then i saw #12028 My issue was with putting watermelon slices and juicing it didn't return any watermelon juice just some reagents like water and nutriment, i assume this solves it? |
|
@XeonMations I am now unable to juice berries, I put the berries in the grinder and press juice, and get nothing. |
|
@XeonMations YOU DID THIS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Turns out juice_typepaths were all lists instead of the proper datums they were supposed to be after #11994. Oops. This fixes that.
Fixes #12028
Also adds a reagent_grinder unit test to check that they are working correctly.
Why It's Good For The Game
You should be able to juice a banana.
Testing Photographs and Procedure
Screenshots&Videos
2024-12-14.14-26-50.mp4
Changelog
🆑 XeonMations
fix: You can now juice things once more in a reagent grinder.
/:cl: