Minor Nitpicks #2741
Open
Minor Nitpicks #2741
+100
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes default/Legacy control > This does *technically* mean that legacy can't use TGUI Say, but nobody using Legacy is going to care. Adds macrotest debug tools Adds Dream Daemon VSCode debug target
francinum
requested review from
Bokkiewokkie,
covertcorvid and
Karmic-Skink
as code owners
covertcorvid
previously approved these changes
Jan 6, 2025
Bokkiewokkie
requested changes
Jan 10, 2025
francinum
commented
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Default input has been broken for 8 months since #2618, due to it directly binding printable keys on legacy users.
The only safe keys to hard-bind on legacy input users is in this random list from 2008.
https://www.byond.com/docs/notes/macro.html
This also comes with a set of janky tools for directly poking at the client skin. They aren't production safe and are behind a compile flag,
MACROTESTYou can now compile targeting Dream Daemon, as god intended. (This boots faster and means your client doesn't try to crash itself when you hit a breakpoint)
Why It's Good For The Game
I got nerd-sniped. I entered the VC as a cheap joke.
Testing Photographs and Procedure
Screenshots&Videos
Nobody but me cares about this anyways.
Changelog
🆑
fix: Default/Legacy input now properly relays keys.
del: TGUI Say and Legacy Input are incompatible, Legacy will take precedence.
/:cl: