Initial Python websocket-client to the Resourcer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Then do `pip install requirements.txt` | ||
|
|
||
| You will need the following env vars set. In Prod, these would be passed in via Beep Boop. | ||
|
|
There was a problem hiding this comment.
More of a reminder... when we point to the Resourcer-dev, we'll want to add instructions on how they fetch these values from the beepboophq site.
|
This looks great. So happy retry memory profile is flat as a pancake. 👍 |
randompi
added a commit
that referenced
this pull request
Mar 15, 2016
Initial Python websocket-client to the Resourcer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Uses the websocket-client module to handle connections to the resourcer and a framework for handling the connection and forwarding messages on to the bot app that will use this connection.
Where should the reviewer start?
See changelist.
How should this be manually tested?
Follow instructions in README, start sample app. Also
export LOG_LEVEL=DEBUG. Stop dev-console process, verify that the app client tries to reconnect in a randomized exponential backoff fashion, with max retry backoff at 32 seconds.Any background context you want to provide?
Made the change to get the retry open websocket connection on close from:
websocket-client/websocket-client#95
Screenshots (if appropriate)
http://i.imgur.com/8dVeY.jpg