Add GCP Compute Engine & Kubernetes Integration #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| user = subprocess.check_output('whoami', shell=True).decode().strip() | ||
|
|
||
| # Username | ||
| self._username = (open(f'/home/{user}/.ssh/google_compute_engine.pub'). |
There was a problem hiding this comment.
It would be nice to break this up into more separate steps, as it is tough to parse what is going on currently.
| pod_config: dict = json.loads(open(f'{kube_wd}/pod.json').read()) | ||
|
|
||
| # Configure the pod | ||
| pod_config['spec']['containers'][0]["image"] = self.container_image |
There was a problem hiding this comment.
Perhaps change the quotations around "image" to be ' to match the rest of the strings.
|
|
||
| # Configure the pod | ||
| pod_config['spec']['containers'][0]["image"] = self.container_image | ||
| pod_config['spec']['containers'][0]["name"] = self._name |
There was a problem hiding this comment.
Perhaps change the quotations around "name" to be ' to match the rest of the strings.
| pod_config['spec']['containers'][0]["image"] = self.container_image | ||
| pod_config['spec']['containers'][0]["name"] = self._name | ||
| pod_config['spec']['containers'][0]['resources']['requests']['memory'] = str(self._mmb) + 'Mi' | ||
| pod_config['spec']['containers'][0]['resources']['requests']['cpu'] = str(self._mcpu) + "m" |
There was a problem hiding this comment.
I suppose for some of these, the string quotations aren't consistent across the board, and it would be great if they could be unified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full support for GCP and Kubernetes.
GCP Usage:
Kubernetes Usage
Requires gcloud CLI and/or kubectl on local host
Changes to review:
ipproperty and now avpn_ipproperty. Kubernetes has separate addresses for the two services so a modification was also made to the VPN classubuntuusername inClouldInstanceKnown Issues: