Update collectives #158
Draft
Update collectives #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@everythingfunctional flang supports kind type parameters for derived types but not length type parameters. Does Caffeine use length type parameters? |
One of the tests was trying to demonstrate how |
Merged
bonachea
reviewed
Jan 2, 2025
This was referenced Jan 16, 2025
test(collectives): outline simpler test suite chore: remove old collective implementations chore: update interfaces of collectives feat(co_broadcast): use wrapper to make contiguous feat: re-implement co_sum feat: create implementation of co_reduce feat: create co_min implementation feat: create implementation for co_max
bonachea
force-pushed
the
update-collectives
branch
from
171bf08 to
6d6ac10
Compare
|
Brad's version at 171bf08 rebased onto main and conflicts resolved manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the collective interfaces and implementations to match the new PRIF revision.
Some of the tests and implementations are currently commented out. This is because of the following compiler bugs:
co_reducecharactersFixes #69
Fixes #132
Fixes #153
Fixes #154
Fixes #155