Fix: Problem with langfuse_tags when using litellm proxy with langfus… #7825
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @staticmethod | ||
| def _get_langfuse_tags(metadata: dict) -> list[str]: | ||
| return json.loads(metadata.pop("tags", "[]")) | ||
|
|
There was a problem hiding this comment.
can you try / except this, (don't raise an exception if there is an error)
you can do `verbose_logger.exception("error getting langfuse tags %s", str(e))
There was a problem hiding this comment.
concern here is json decode / encode errors
There was a problem hiding this comment.
Thank you for your feedback.
If the tags cannot be converted to JSON successfully, should I convert an empty array? Or, because the severity is "error", should I avoid sending the data to Langfuse and return a non-200 status code to the client?
The previous behavior was to forcibly append to a string, so the request was treated as not being sent to Langfuse in the first place.
current code.
@staticmethod
def _get_langfuse_tags(metadata: dict) -> list[str]:
try:
return json.loads(metadata.pop("tags", "[]"))
except Exception as e:
verbose_logger.exception("error getting langfuse tags %s", str(e))
return []current logs
09:47:02 - LiteLLM:ERROR: langfuse.py:740 - error getting langfuse tags Expecting property name enclosed in double quotes: line 1 column 2 (char 1)
Traceback (most recent call last):
File "/home/ubuntu/work/xxx/venv/lib/python3.12/site-packages/litellm/integrations/langfuse/langfuse.py", line 738, in _get_langfuse_tags
return json.loads(metadata.pop("tags", "[]"))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/json/__init__.py", line 346, in loads
return _default_decoder.decode(s)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/json/decoder.py", line 353, in raw_decode
obj, end = self.scan_once(s, idx)
^^^^^^^^^^^^^^^^^^^^^^
There was a problem hiding this comment.
returning an array is fine
There was a problem hiding this comment.
I have pushed the implementation above as is. Please review it.
Title
Fix: Problem with langfuse_tags when using litellm proxy with langfuse integration
Relevant issues
Fixes #7801
Type
🐛 Bug Fix
Changes
[REQUIRED] Testing - Attach a screenshot of any new tests passing locally
If UI changes, send a screenshot/GIF of working UI fixes