Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add static linking #3

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

add static linking #3

wants to merge 8 commits into from

Conversation

andrewgazelka
Copy link

No description provided.

@TobiasDeBruijn
Copy link
Contributor

I like this idea!

I do have some questions though:

  • Why specific paths for GCC 10 and 11? (and why not 12?)
  • Would it not be better to use e.g. pkgconfig on Linux and whatever Windows has? (Does EspeakNG support Windows?)

Thanks!

@andrewgazelka
Copy link
Author

yea I need to clean up this PR a bit.

  • the specific paths are related to linking std++. I suppose I can include 12. Ideally I would not have to do this. If you are familiar with static linking I would definitely be open to hearing your thoughts as I have not done this a lot before
  • when you talk about pkgconfig are you refering to https://crates.io/crates/pkg-config?

TobiasDeBruijn
TobiasDeBruijn requested changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@TobiasDeBruijn TobiasDeBruijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late reply! Exams took a toll on free time I'm afraid.

Looks good overall, just some minor things!

build.rs
Command::new("git")
.args([
"clone",
"https://github.com/espeak-ng/espeak-ng",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use tags rather than the latest master to avoid breaking down stream users if something changes up-stream (could be a feature?)

build.rs
.args([
"--prefix",
&espeak_build_dir,
"--without-sonic",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure what these do, why should they be disabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiasDeBruijn TobiasDeBruijn TobiasDeBruijn requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewgazelka @TobiasDeBruijn