WIP: add composite actions

Beuterei · Dec 17, 2024 · f076bfe · f076bfe
1 parent 0fd1dfb
commit f076bfe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/.github/actions/node-qa-testing/action.yml b/.github/actions/node-qa-testing/action.yml
@@ -3,6 +3,7 @@ description: 'Runs QA testing with Node.js supporting both Bun and npm'
 
 # TODO: Add coverage support
 # TODO: Use Eslint
+# TODO: Split into separate "tooling" actions
 inputs:
   format_script:
     description: 'Format script to run. Disabled by default'

diff --git a/.github/actions/upload-to-s3/action.yml b/.github/actions/upload-to-s3/action.yml
@@ -38,11 +38,13 @@ runs:
         aws-region: ${{ inputs.aws_region }}
         mask-aws-account-id: true
 
+    - name: Set endpoint URL
+      if: inputs.endpoint_url != ''
+      shell: bash
+      run: |
+        aws configure set s3.endpoint_url ${{ inputs.endpoint_url }}
+
     - name: Deploy to S3
       shell: bash
       run: |
-        if [ -n "${{ inputs.endpoint_url }}" ]; then
-          aws s3 sync ${{ inputs.path_to_upload }} s3://${{ inputs.s3_bucket }}/${{ inputs.target_path }} --delete --endpoint-url ${{ inputs.endpoint_url }}
-        else
-          aws s3 sync ${{ inputs.path_to_upload }} s3://${{ inputs.s3_bucket }}/${{ inputs.target_path }} --delete
-        fi
+        aws s3 sync ${{ inputs.path_to_upload }} s3://${{ inputs.s3_bucket }}/${{ inputs.target_path }} --delete