Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config issues #38

Merged
merged 5 commits into from
May 23, 2024
Merged

Fix config issues #38

merged 5 commits into from
May 23, 2024

Conversation

kueblc
Copy link

@kueblc kueblc commented May 17, 2024

Which issues are addressed by this Pull Request?

#22, and several unreported issues:

  • Client config placeholders do not represent defaults
  • Required config is too strict, many options can be passed via payload
  • After error, client will not have listeners set up

What does this Pull Request change?

  • Respect client config.interface
  • Show defaults as placeholders on client config
  • Do not enforce device/interface on read/write nodes, as these can be passed in
  • Set up client listeners when instantiating a new client

Does this Pull Request introduce any potentially breaking changes?

  • No breaking changes, only fixes with this PR

@kueblc kueblc force-pushed the fix-config-issues branch from 55f5bc7 to 96cfeab Compare May 18, 2024 03:44
@biancode biancode changed the base branch from master to develop May 23, 2024 15:02
@biancode biancode self-assigned this May 23, 2024
@biancode biancode merged commit daafd7f into BiancoRoyal:develop May 23, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@biancode biancode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kueblc @biancode