Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalize macro helper, add support for tick cb's #21

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Rationalize macro helper, add support for tick cb's #21

merged 8 commits into from
Apr 8, 2024

Conversation

tascord
Copy link
Collaborator

@tascord tascord commented Mar 11, 2024

Holy moly did someone say #20 ??

  • Adds support for options.scales[scale].callback as an FnWithArgs
  • Simplifies the rationalizing process with a rationalize!() macro (see utils.rs)

@tascord tascord mentioned this pull request Mar 12, 2024
Closed
@Billy-Sheppard
Copy link
Owner

Billy-Sheppard commented Mar 12, 2024 •
edited
Loading

Looks good, can you please bump the Cargo.toml version to 0.0.20? Thank you for fixing the issue!

@Billy-Sheppard Billy-Sheppard merged commit a80aa06 into Billy-Sheppard:main Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Billy-Sheppard Billy-Sheppard Billy-Sheppard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tascord @Billy-Sheppard