Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for line chart #9

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

manthanrtilva
Copy link

This PR add support to plot line chart.
Add example for line chart.

Signed-off-by: Manthan R. Tilva <[email protected]>
Signed-off-by: Manthan R. Tilva <[email protected]>
@Billy-Sheppard
Copy link
Owner

Thanks for contributing!

Line charts are available by leveraging scatter plots, can you explain how this is different? I don't want to add extra chart types if they can be done with the existing set.

It might be worth me adding a line example to the code using the scatter plot code, I would be happy to do that if this isn't merged.

@DDtKey
Copy link

DDtKey commented Jan 21, 2024

Hi there!

As far as I understand to use Scatter instead of Line chart we need to be able to set showLine: true, but currently I don't see this property.

The scatter chart supports all the same properties as the line chart. By default, the scatter chart will override the showLine property of the line chart to false.

And in general, it could work just by setting r#type: "line", but it's not possible ofc due to private types and it makes sense. But would be nice to have wrapper for Line charts or add showLine config at least

@Billy-Sheppard
Copy link
Owner

Hi @DDtKey!

I've added a line chart to the examples, please let me know if this is not suitable for your use case/doesn't answer your question.

@DDtKey
Copy link

DDtKey commented Jan 22, 2024

Thanks @Billy-Sheppard, it works as expected to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants