feat: add infinite scroll and pagination to notificationspopover gf-458 #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fjortis
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Fjortis
changed the title
|
Do we want the notification title to be sticky? option.2.notifications.mp4 |
Fjortis
requested review from
what1s1ove,
liza-veis and
yevhenii-hladkov
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
what1s1ove
reviewed
Sep 23, 2024
...d/src/libs/components/header/libs/components/notifications-popover/notifications-popover.tsx
Outdated
Show resolved
Hide resolved
...d/src/libs/components/header/libs/components/notifications-popover/notifications-popover.tsx
Outdated
Show resolved
Hide resolved
GvoFor
reviewed
Sep 23, 2024
apps/backend/src/modules/notifications/notification.controller.ts
Outdated
Show resolved
Hide resolved
liza-veis
requested changes
Sep 23, 2024
apps/frontend/src/modules/notifications/slices/notification.slice.ts
Outdated
Show resolved
Hide resolved
.../frontend/src/libs/components/header/libs/components/notifications-popover/styles.module.css
Outdated
Show resolved
Hide resolved
...ts/header/libs/components/notifications-popover/libs/constants/default-page-size.constant.ts
Outdated
Show resolved
Hide resolved
liza-veis
reviewed
Sep 23, 2024
apps/backend/src/modules/notifications/notification.controller.ts
Outdated
Show resolved
Hide resolved
Fjortis
changed the title
GvoFor
reviewed
Sep 23, 2024
liza-veis
approved these changes
Sep 23, 2024
This was referenced Sep 24, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented infinite scroll for the NotificationsPopover component.
Added pagination handling to load notifications incrementally.
Screen.Recording.2024-09-23.145833.mp4