Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjusted search for modal to remove double reload gf-455 #493

Merged
merged 3 commits into from
Sep 23, 2024
Merged

fix: adjusted search for modal to remove double reload gf-455 #493

merged 3 commits into from
Sep 23, 2024

Conversation

Fjortis
Copy link
Collaborator

@Fjortis Fjortis commented Sep 23, 2024

  • Made use of the isSavedToUrl: false prop to avoud double reload on the modal
Test.of.search.function.mp4

@Fjortis Fjortis added this to the git-fit-release-6 milestone Sep 23, 2024
@Fjortis Fjortis self-assigned this Sep 23, 2024
@github-actions github-actions bot added the root label Sep 23, 2024
@Fjortis Fjortis marked this pull request as ready for review September 23, 2024 14:23
@Fjortis Fjortis removed the conflicts label Sep 23, 2024
@liza-veis liza-veis merged commit d80d5c5 into main Sep 23, 2024
9 checks passed
This was referenced Sep 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liza-veis liza-veis liza-veis approved these changes

@what1s1ove what1s1ove what1s1ove approved these changes

@yevhenii-hladkov yevhenii-hladkov Awaiting requested review from yevhenii-hladkov yevhenii-hladkov is a code owner

Assignees

@Fjortis Fjortis

Labels
bug frontend root
Projects
bsa-2024-gitfit
Status: Backlog
Milestone
git-fit-release-6
Development

Successfully merging this pull request may close these issues.
3 participants
@Fjortis @what1s1ove @liza-veis