feat: fix quality criteria issues gf-557 #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitaliistf
requested review from
what1s1ove,
liza-veis and
yevhenii-hladkov
as code owners
| @@ -1,3 +1,3 @@ | |||
| <svg width="18" height="18" viewBox="0 0 18 18" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
| <svg width="18" height="18" viewBox="0 0 18 18" fill="currentColor" xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
I have only one question. Why do we need to replace fill="none"?
There was a problem hiding this comment.
It's just for consistency. Either "currentColor" or "none". I chose "currentColor" because some icons don't have fill in path tag. Maybe it will be not so confusing as it would be if we had "none" (and no path).
liza-veis
approved these changes
Sep 27, 2024
|
Could you also please fix OrderKey from @GvoFor pull request? |
Oh, yeah, sorry, I've changed it but forgot to add to commit😅 |
Signed-off-by: Vitalii Stefaniv <[email protected]>
what1s1ove
approved these changes
Sep 27, 2024
This was referenced Sep 27, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
Besides fixes that were described in ticket, I've changed case of all table and column names in objection queries (except for raw parts of queries of course).