Skip to content

Commit

Permalink
Merge branch 'next' into task/OV-6-add-loader
Browse files Browse the repository at this point in the history
  • Loading branch information
sergiy4 committed Aug 19, 2024
2 parents 9c55dfd + 2f36f54 commit 6d42a55
Show file tree
Hide file tree
Showing 9 changed files with 25 additions and 52 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Bug Report
description: Report a bug
title: 'BUG:'
labels: ['BUG']
projects: "BinaryStudioAcademy/30"
projects: 'BinaryStudioAcademy/30'
body:
- type: markdown
attributes:
Expand Down
38 changes: 19 additions & 19 deletions .github/ISSUE_TEMPLATE/feature.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
name: Feature
description: Abstract feature description
title: "FEAT:"
projects: "BinaryStudioAcademy/30"
title: 'FEAT:'
projects: 'BinaryStudioAcademy/30'
body:
- type: textarea
id: what-feature
attributes:
label: What feature?
placeholder: Add descriptions
validations:
required: true
- type: textarea
id: screenshots
attributes:
label: Add screenshots
placeholder: Add screenshots, mockups, etc.
- type: textarea
id: acceptance-criteria
attributes:
label: Acceptance criteria
placeholder: Add acceptance criteria.
- type: textarea
id: what-feature
attributes:
label: What feature?
placeholder: Add descriptions
validations:
required: true
- type: textarea
id: screenshots
attributes:
label: Add screenshots
placeholder: Add screenshots, mockups, etc.
- type: textarea
id: acceptance-criteria
attributes:
label: Acceptance criteria
placeholder: Add acceptance criteria.
14 changes: 0 additions & 14 deletions .github/labeler.yml

This file was deleted.

11 changes: 0 additions & 11 deletions .github/workflows/ci-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,3 @@ jobs:

run: |
npx danger ci --failOnErrors --text-only
- name: Add Folder Labels
uses: actions/labeler@v4
with:
repo-token: '${{ secrets.GITHUB_TOKEN }}'
sync-labels: true

- name: Add Environment Labels
uses: ffittschen/pr-branch-labeler@v1
with:
repo-token: '${{ secrets.GITHUB_TOKEN }}'
2 changes: 1 addition & 1 deletion .ls-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ ls:
.ts: snake_case

ignore:
- .git
- .github
- node_modules
- build
- shared/build
Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"npm": "10.x.x"
},
"scripts": {
"lint:css": "npx stylelint \"src/**/*.scss\"",
"lint:css": "npx stylelint \"src/**/*.scss\" --aei",
"lint:js": "npx eslint \"src/**/*.{ts,tsx}\"",
"lint:type": "npx tsc --noEmit",
"lint": "npm run lint:type && npm run lint:js",
Expand Down
4 changes: 1 addition & 3 deletions frontend/src/framework/config/base-config.package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ class BaseConfig implements Config {
private get envSchema(): EnvironmentSchema {
return {
APP: {
ENVIRONMENT: import.meta.env[
'VITE_APP_NODE_ENV'
],
ENVIRONMENT: import.meta.env['VITE_APP_NODE_ENV'],
},
API: {
ORIGIN_URL: import.meta.env[
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { type AppEnvironment } from '~/bundles/common/enums/enums.js';
import { type ValueOf } from '~/bundles/common/types/types.js';
import { type ValueOf } from '~/bundles/common/types/types.js';

type EnvironmentSchema = {
APP: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { type ContentType } from '~/bundles/common/enums/enums.js';
import { type ValueOf } from '~/bundles/common/types/types.js';
import { type ValueOf } from '~/bundles/common/types/types.js';
import { type HttpOptions } from '~/framework/http/http.js';

type HttpApiOptions = Omit<HttpOptions, 'headers' | 'payload'> & {
Expand Down

0 comments on commit 6d42a55

Please sign in to comment.